Box Item::Attributes #80802
Merged
Box Item::Attributes #80802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
T-rustdoc
This comment has been minimized.
This comment has been minimized.
rust-highfive
added
the
S-waiting-on-review
jyn514
added
S-blocked
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Looks good for now. I'll re-review once #80339 has been merged. Also, might be worth it to have a perf run too. |
|
☔ The latest upstream changes (presumably #80867) made this pull request unmergeable. Please resolve the merge conflicts. |
jyn514
force-pushed
the
box-attributes
branch
2 times, most recently
from
6d21dd3 to
030e1c9
Compare
This reduces the size of Item from 136 to 48 bytes.
jyn514
force-pushed
the
box-attributes
branch
from
030e1c9 to
690aeaf
Compare
jyn514
added
S-waiting-on-review
|
@bors try @rust-timer queue This didn't actually depend on #80339, I was just too lazy to change it. Since that isn't getting merged any time soon I dropped those changes. |
|
Awaiting bors try build completion. |
|
⌛ Trying commit 690aeaf with merge 2420bbf76cea896b7592e5edbbf9be549d1c8f3e... |
|
☀️ Try build successful - checks-actions |
|
Queued 2420bbf76cea896b7592e5edbbf9be549d1c8f3e with parent fd34606, future comparison URL. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
Finished benchmarking try commit (2420bbf76cea896b7592e5edbbf9be549d1c8f3e): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
|
Interesting. Up to -.6% on serde-doc (which is probably the closest we have to a realistic rustdoc benchmark), but up to +.2% on other several other benches, including hello world and await-call-tree. Max-rss is all over the place. One reason this might be slow is that attributes are accessed a lot, here's
|
|
@bors r+ |
|
📌 Commit 690aeaf has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 690aeaf with merge ab80a582cfb3c1ab6117d842406e32bbe036e509... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Looks spurious: @bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Jan 14, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size of Item from 128 to 40 bytes. I think this is as small as it needs to get 🎉
Builds on #80339 and should not be merged before.
r? @GuillaumeGomez