Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feature-gate pointer and reference in intra-doc links #81015

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Feature-gate pointer and reference in intra-doc links #81015

merged 1 commit into from
Jan 18, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jan 14, 2021 •
edited
Loading

r? @camelid

Addresses (but does not close) #80896.

@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name labels Jan 14, 2021
@rust-highfive

This comment has been minimized.

# to view
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2021
@jyn514

This comment has been minimized.

# to view
@rust-log-analyzer

This comment has been minimized.

# to view
@rust-log-analyzer

This comment has been minimized.

# to view
@camelid

This comment has been minimized.

# to view
@rust-log-analyzer

This comment has been minimized.

# to view
@camelid
Copy link
Member

camelid commented Jan 15, 2021

FYI, you accidentally committed some submodules :)

@jyn514
Copy link
Member Author

jyn514 commented Jan 15, 2021

Thanks, fixed.

@bors

This comment has been minimized.

# to view
@jyn514
Feature-gate pointer and reference in intra-doc links
fc53594 
- Only feature gate associated items
- Add docs to unstable book
@jyn514
Copy link
Member Author

jyn514 commented Jan 17, 2021

@camelid did you have other concerns for me to address?

@camelid
Copy link
Member

camelid commented Jan 17, 2021

I see that you had to adjust tidy so it checks test/rustdoc-ui for feature gates. I don't know tidy but it seems harmless, so r=me.

@jyn514
Copy link
Member Author

jyn514 commented Jan 17, 2021

Thanks!

@bors r=camelid

@bors
Copy link
Contributor

bors commented Jan 17, 2021

📌 Commit fc53594 has been approved by camelid

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2021
@bors
Copy link
Contributor

bors commented Jan 18, 2021

⌛ Testing commit fc53594 with merge 66eb982...

@bors
Copy link
Contributor

bors commented Jan 18, 2021

☀️ Test successful - checks-actions
Approved by: camelid
Pushing 66eb982 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 18, 2021
@bors bors merged commit 66eb982 into rust-lang:master Jan 18, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 18, 2021
This was referenced Jan 18, 2021
Closed
Merged
@jyn514 jyn514 deleted the feature-gate-ptr branch January 18, 2021 15:04
@jyn514 jyn514 mentioned this pull request Jan 18, 2021
Merged
3 tasks
@jyn514 jyn514 mentioned this pull request Feb 22, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@camelid camelid camelid left review comments

Assignees

@camelid camelid

Labels
A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jyn514 @rust-highfive @rust-log-analyzer @camelid @bors @rustbot