Remove hack for actix-web and actori-web #81174

Aaron1011 · 2021-01-18T19:43:52Z

Hopefully, most affected crates have run cargo update by now. If not,
I'll explore phasing this out gradually.

r? @ghost

Hopefully, most affected crates have run `cargo update` by now. If not, I'll explore phasing this out gradually.

Aaron1011 · 2021-01-18T19:44:01Z

@bors try

bors · 2021-01-18T19:44:11Z

⌛ Trying commit 0153f7d with merge f5e1d18a431fc2bb12c57c3144ce68e79f06b514...

bors · 2021-01-18T20:44:37Z

☀️ Try build successful - checks-actions
Build commit: f5e1d18a431fc2bb12c57c3144ce68e79f06b514 (f5e1d18a431fc2bb12c57c3144ce68e79f06b514)

Aaron1011 · 2021-01-18T20:48:02Z

@craterbot check

craterbot · 2021-01-18T20:48:13Z

👌 Experiment pr-81174 created and queued.
🤖 Automatically detected try build f5e1d18a431fc2bb12c57c3144ce68e79f06b514
⚠️ Try build based on commit 5e91c4e, but latest commit is 0153f7d. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

ThePuzzlemaker · 2021-01-19T00:16:21Z

Huh. I’m curious. When exactly was this introduced and why?

Aaron1011 · 2021-01-19T01:20:35Z

@ThePuzzlemaker This was introduced in 9a6ea38, as part of #77135. That PR made us preserve the original TokenStream in more cases, making progress towards fixing the longstanding compiler bug #43081.

Unfortunately, this change broke actix-web and actori-web, since they used an older version of syn that was not prepared to handle the None-delimited groups present in the new TokenStream input. As a result, I added this hack to allow those crates to continue to compile, while still allowing us to preserve Spans in the input TokenStream.

However, having the compiler special-case certain filenames is a really awful hack. I'd like to get rid of this as soon as possible - unfortunately, there may be a large number of Cargo.lock files onGitHub that need to be updated.

pietroalbini · 2021-01-19T19:32:04Z

@craterbot run start=master#5e91c4ecc09312d8b63d250a432b0f3ef83f1df7 end=try#5e91c4ecc09312d8b63d250a432b0f3ef83f1df7 mode=check-only

craterbot · 2021-01-19T19:32:13Z

👌 Experiment pr-81174 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2021-01-22T13:36:27Z

🚧 Experiment pr-81174 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Aaron1011 · 2021-01-23T18:31:05Z

@pietroalbini It looks like you specified the same start and end commit?

Aaron1011 · 2021-01-23T18:32:24Z

@craterbot abort

craterbot · 2021-01-23T18:32:40Z

🗑️ Experiment pr-81174 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Aaron1011 · 2021-01-23T18:33:17Z

@bors try

bors · 2021-01-23T18:33:27Z

⌛ Trying commit 0153f7d with merge 9cfe725f0995b018340c519db1b2f3cf8a7e0631...

bors · 2021-01-23T19:17:25Z

☀️ Try build successful - checks-actions
Build commit: 9cfe725f0995b018340c519db1b2f3cf8a7e0631 (9cfe725f0995b018340c519db1b2f3cf8a7e0631)

Aaron1011 · 2021-01-23T19:17:53Z

@craterbot check

craterbot · 2021-01-23T19:17:57Z

👌 Experiment pr-81174 created and queued.
🤖 Automatically detected try build 9cfe725f0995b018340c519db1b2f3cf8a7e0631
⚠️ Try build based on commit 4d0dd02, but latest commit is 0153f7d. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2021-01-26T12:20:19Z

🚧 Experiment pr-81174 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2021-01-28T11:53:33Z

🚨 Experiment pr-81174 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2021-01-28T12:05:48Z

🚨 Experiment pr-81174 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2021-01-28T12:09:37Z

🚨 Experiment pr-81174 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

pietroalbini · 2021-01-28T12:43:27Z

@craterbot retry

craterbot · 2021-01-28T12:43:29Z

🛠️ Experiment pr-81174 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2021-01-28T12:47:36Z

🚨 Experiment pr-81174 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

pietroalbini · 2021-01-28T12:57:43Z

Sorry about that. A new crater deployment broke a thing. Should be fixed now.

@craterbot retry p=3

craterbot · 2021-01-28T12:57:45Z

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

pietroalbini · 2021-01-28T12:58:57Z

@craterbot retry

craterbot · 2021-01-28T12:58:59Z

🛠️ Experiment pr-81174 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

pietroalbini · 2021-01-28T12:59:07Z

@craterbot p=3

craterbot · 2021-01-28T12:59:08Z

📝 Configuration of the pr-81174 experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2021-01-28T13:24:15Z

🚧 Experiment pr-81174 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2021-01-29T15:01:55Z

🎉 Experiment pr-81174 is completed!
📊 394 regressed and 9 fixed (142067 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

crlf0710 · 2021-03-12T17:20:40Z

Ping from triage @Aaron1011 : it seems some crates like actix-web 2.0.0 and actix-web 3.0.0 still regresses after this change. What's next steps here?

Aaron1011 · 2021-04-03T19:22:23Z

The actori-web hack was removed entirely, and we are now linting whenver we apply the actix-web hack.

Remove hack for actix-web and actori-web

0153f7d

Hopefully, most affected crates have run `cargo update` by now. If not, I'll explore phasing this out gradually.

craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jan 18, 2021

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 23, 2021

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2021

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 29, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2021

crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2021

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2021

Aaron1011 closed this Apr 3, 2021

Remove hack for actix-web and actori-web #81174

Remove hack for actix-web and actori-web #81174

Uh oh!

Conversation

Aaron1011 commented Jan 18, 2021

Uh oh!

Aaron1011 commented Jan 18, 2021

Uh oh!

bors commented Jan 18, 2021

Uh oh!

bors commented Jan 18, 2021

Uh oh!

Aaron1011 commented Jan 18, 2021

Uh oh!

craterbot commented Jan 18, 2021

Uh oh!

ThePuzzlemaker commented Jan 19, 2021

Uh oh!

Aaron1011 commented Jan 19, 2021 • edited by petrochenkov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pietroalbini commented Jan 19, 2021

Uh oh!

craterbot commented Jan 19, 2021

Uh oh!

craterbot commented Jan 22, 2021

Uh oh!

Aaron1011 commented Jan 23, 2021

Uh oh!

Aaron1011 commented Jan 23, 2021

Uh oh!

craterbot commented Jan 23, 2021

Uh oh!

Aaron1011 commented Jan 23, 2021

Uh oh!

bors commented Jan 23, 2021

Uh oh!

bors commented Jan 23, 2021

Uh oh!

Aaron1011 commented Jan 23, 2021

Uh oh!

craterbot commented Jan 23, 2021

Uh oh!

craterbot commented Jan 26, 2021

Uh oh!

craterbot commented Jan 28, 2021

Uh oh!

craterbot commented Jan 28, 2021

Uh oh!

craterbot commented Jan 28, 2021

Uh oh!

pietroalbini commented Jan 28, 2021

Uh oh!

craterbot commented Jan 28, 2021

Uh oh!

craterbot commented Jan 28, 2021

Uh oh!

pietroalbini commented Jan 28, 2021

Uh oh!

craterbot commented Jan 28, 2021

Uh oh!

pietroalbini commented Jan 28, 2021

Uh oh!

craterbot commented Jan 28, 2021

Uh oh!

pietroalbini commented Jan 28, 2021

Uh oh!

craterbot commented Jan 28, 2021

Uh oh!

craterbot commented Jan 28, 2021

Uh oh!

craterbot commented Jan 29, 2021

Uh oh!

crlf0710 commented Mar 12, 2021

Uh oh!

Aaron1011 commented Apr 3, 2021

Uh oh!

Uh oh!

Aaron1011 commented Jan 19, 2021 •

edited by petrochenkov

Loading