const_evaluatable: consider sub-expressions to be evaluatable #81577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
lcnr
added
A-const-generics
|
@bors r+ |
|
📌 Commit f6bab65 has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- failed in #81622 (comment) |
bors
added
S-waiting-on-author
|
you need to rebase. I think your previous PR is not in the history of this one, so the call to |
BoxyUwU
force-pushed
the
subexpr_const_evaluatable
branch
from
f6bab65 to
d9e0ad4
Compare
|
The places that are erroring in that rollup dont seem to have any calls to walk_abstract_const on master branch so I think maybe one of the other PR's added them |
|
You're right, it conflicts with #79291 |
|
let's wait for the other PR to merge first |
BoxyUwU
force-pushed
the
subexpr_const_evaluatable
branch
from
d9e0ad4 to
7f8530f
Compare
|
that PR seems to have been merged so fingers crossed there are no other PR's that use walk_abstract_const lurking around lol |
|
@bors r=oli-obk |
|
📌 Commit 7f8530f has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 2, 2021
…as-schievink Rollup of 11 pull requests Successful merges: - rust-lang#80629 (Add lint for 2229 migrations) - rust-lang#81022 (Add Frames Iterator for Backtrace) - rust-lang#81481 (move some tests) - rust-lang#81485 (Add some tests for associated-type-bounds issues) - rust-lang#81492 (rustdoc: Note why `rustdoc::html::markdown` is public) - rust-lang#81577 (const_evaluatable: consider sub-expressions to be evaluatable) - rust-lang#81599 (Implement `TrustedLen` for `Fuse<I: TrustedLen>`) - rust-lang#81608 (Improve handling of spans around macro result parse errors) - rust-lang#81609 (Remove the remains of query categories) - rust-lang#81630 (Fix overflowing text on mobile when sidebar is displayed) - rust-lang#81631 (Remove unneeded `mut` variable) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
16 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see zulip topic for more info
cc @lcnr
r? @oli-obk