-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Prepare beta 1.51.0 #81921
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Prepare beta 1.51.0 #81921
Conversation
@bors r+ p=1000 rollup=never |
📌 Commit bae1a0a has been approved by |
This comment has been minimized.
This comment has been minimized.
@bors r- |
@bors r+ p=1000 rollup=never |
📌 Commit 4745585 has been approved by |
⌛ Testing commit 4745585 with merge 1dddb472b0e764de5d2029560576f36a5b706cb9... |
This comment has been minimized.
This comment has been minimized.
📌 Commit e708e2a has been approved by |
⌛ Testing commit e708e2a with merge 30b51f4208197b622efafc707a28c08007f2cb37... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
Seems like rustfmt depends on an old version of |
Hm. cc @calebcartwright It looks like we'll probably want to either bump rustfmt or do some other fix, not really sure... |
Did you intend to apply this PR to the master branch? |
|
#81768 has been merged and RLS/Rustfmt toolstate is green now. |
Thanks! Cherry-picked the following two PRs:
@bors r+ p=500 rollup=never |
📌 Commit 9e98dfe has been approved by |
This comment has been minimized.
This comment has been minimized.
@bors r+ p=500 rollup=never |
📌 Commit e15d61c has been approved by |
⌛ Testing commit e15d61c with merge db5d098b874fab52e044fca0b96644bef0503c3a... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
This is an instance of #79132 (comment), which probably needs a 7477867 backport for now. I'm sorry that RLS doesn't build on aarch64-pc-windows-msvc proper - this was somehow alleviated by rust-lang/rls#1713 but not completely fixed - we ideally would upgrade to Tokio 1.0 (along with core jsonrpc-* deps) but that's not possible due to parity-tokio-ipc being blocked on paritytech/parity-tokio-ipc#30 (which is effectively blocked on Tokio design work in tokio-rs/tokio#3118). However, I believe the RLS should build (but not pass tests, as these unconditionally require Tokio) with We might:
Solution no. 2 seems easiest and is proven to work (#79132) but if we try going with solution no. 1, if we don't need to hack |
📌 Commit b2d3220 has been approved by |
☀️ Test successful - checks-actions |
cc @rust-lang/release
r? @ghost