Fix suggestion to introduce explicit lifetime #81995

0yoyoyo · 2021-02-11T15:57:14Z

Addresses #81650

Error message after fix:

error[E0311]: the parameter type `T` may not live long enough
  --> src/main.rs:25:11
   |
24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) {
   |              -- help: consider adding an explicit lifetime bound...: `T: 'a +`
25 |     scope.spawn(move |_| {
   |           ^^^^^
   |
note: the parameter type `T` must be valid for the anonymous lifetime #2 defined on the function body at 24:1...
  --> src/main.rs:24:1
   |
24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...so that the type `[closure@src/main.rs:25:17: 27:6]` will meet its required lifetime bounds
  --> src/main.rs:25:11
   |
25 |     scope.spawn(move |_| {
   |           ^^^^^

rust-highfive · 2021-02-11T15:57:17Z

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

0yoyoyo · 2021-02-11T16:27:39Z

r? @estebank

estebank · 2021-02-11T17:47:13Z

@bors r+

Let's not close the original report. This PR addresses the bad suggestion, but if you now follow the suggestion chain the compiler sends you in, we never point at Foo needing a lifetime. We need to address that as well.

bors · 2021-02-11T17:47:15Z

📌 Commit 788e4bb has been approved by estebank

…fetime-error, r=estebank Fix suggestion to introduce explicit lifetime Addresses rust-lang#81650 Error message after fix: ``` error[E0311]: the parameter type `T` may not live long enough --> src/main.rs:25:11 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | -- help: consider adding an explicit lifetime bound...: `T: 'a +` 25 | scope.spawn(move |_| { | ^^^^^ | note: the parameter type `T` must be valid for the anonymous lifetime #2 defined on the function body at 24:1... --> src/main.rs:24:1 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ note: ...so that the type `[closure@src/main.rs:25:17: 27:6]` will meet its required lifetime bounds --> src/main.rs:25:11 | 25 | scope.spawn(move |_| { | ^^^^^ ```

JohnTitor · 2021-02-12T10:29:46Z

Failed in rollup: #82019 (comment)
Should bless the test with nll mode.
@bors r-

0yoyoyo · 2021-02-12T12:58:39Z

Thank you for following up. I pushed nll test.
But this is my first time to add nll test and I'm not sure it is correct. (I added a file to pass the test with --compare-mode=nll. Is it enough?)

0yoyoyo · 2021-02-12T13:40:14Z

@rustbot label -S-waiting-on-author +S-waiting-on-review

JohnTitor · 2021-02-12T15:24:09Z

That's it, thanks!
@bors r=estebank

bors · 2021-02-12T15:24:11Z

📌 Commit fcce998 has been approved by estebank

Rollup of 8 pull requests Successful merges: - rust-lang#81811 (Fix doc test for Vec::retain(), now passes clippy::eval_order_dependence) - rust-lang#81900 (Organize trait test files) - rust-lang#81995 (Fix suggestion to introduce explicit lifetime) - rust-lang#82031 (Drop an unnecessary intermediate variable) - rust-lang#82033 (Refactor `get_word_attr` to return only `Option`) - rust-lang#82040 (Add test to prevent src link regression) - rust-lang#82041 (Add docs for shared_from_slice From impls) - rust-lang#82050 (Added tests to drain an empty vec) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…onymous-lifetime, r=estebank Improve anonymous lifetime note to indicate the target span Improvement for rust-lang#81650 Cc rust-lang#81995 Message after this improvement: (Improve note in the middle) ``` error[E0311]: the parameter type `T` may not live long enough --> src/main.rs:25:11 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | -- help: consider adding an explicit lifetime bound...: `T: 'a +` 25 | scope.spawn(move |_| { | ^^^^^ | note: the parameter type `T` must be valid for the anonymous lifetime defined on the function body at 24:40... --> src/main.rs:24:40 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | ^^^^^ note: ...so that the type `[closure@src/main.rs:25:17: 27:6]` will meet its required lifetime bounds --> src/main.rs:25:11 | 25 | scope.spawn(move |_| { | ^^^^^ ``` r? `@estebank`

…onymous-lifetime, r=estebank Improve anonymous lifetime note to indicate the target span Improvement for rust-lang#81650 Cc rust-lang#81995 Message after this improvement: (Improve note in the middle) ``` error[E0311]: the parameter type `T` may not live long enough --> src/main.rs:25:11 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | -- help: consider adding an explicit lifetime bound...: `T: 'a +` 25 | scope.spawn(move |_| { | ^^^^^ | note: the parameter type `T` must be valid for the anonymous lifetime defined on the function body at 24:40... --> src/main.rs:24:40 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | ^^^^^ note: ...so that the type `[closure@src/main.rs:25:17: 27:6]` will meet its required lifetime bounds --> src/main.rs:25:11 | 25 | scope.spawn(move |_| { | ^^^^^ ``` r? ``@estebank``

…onymous-lifetime, r=estebank Improve anonymous lifetime note to indicate the target span Improvement for rust-lang#81650 Cc rust-lang#81995 Message after this improvement: (Improve note in the middle) ``` error[E0311]: the parameter type `T` may not live long enough --> src/main.rs:25:11 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | -- help: consider adding an explicit lifetime bound...: `T: 'a +` 25 | scope.spawn(move |_| { | ^^^^^ | note: the parameter type `T` must be valid for the anonymous lifetime defined on the function body at 24:40... --> src/main.rs:24:40 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | ^^^^^ note: ...so that the type `[closure@src/main.rs:25:17: 27:6]` will meet its required lifetime bounds --> src/main.rs:25:11 | 25 | scope.spawn(move |_| { | ^^^^^ ``` r? ```@estebank```

…onymous-lifetime, r=estebank Improve anonymous lifetime note to indicate the target span Improvement for rust-lang#81650 Cc rust-lang#81995 Message after this improvement: (Improve note in the middle) ``` error[E0311]: the parameter type `T` may not live long enough --> src/main.rs:25:11 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | -- help: consider adding an explicit lifetime bound...: `T: 'a +` 25 | scope.spawn(move |_| { | ^^^^^ | note: the parameter type `T` must be valid for the anonymous lifetime defined on the function body at 24:40... --> src/main.rs:24:40 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | ^^^^^ note: ...so that the type `[closure@src/main.rs:25:17: 27:6]` will meet its required lifetime bounds --> src/main.rs:25:11 | 25 | scope.spawn(move |_| { | ^^^^^ ``` r? ````@estebank````

…onymous-lifetime, r=estebank Improve anonymous lifetime note to indicate the target span Improvement for rust-lang#81650 Cc rust-lang#81995 Message after this improvement: (Improve note in the middle) ``` error[E0311]: the parameter type `T` may not live long enough --> src/main.rs:25:11 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | -- help: consider adding an explicit lifetime bound...: `T: 'a +` 25 | scope.spawn(move |_| { | ^^^^^ | note: the parameter type `T` must be valid for the anonymous lifetime defined on the function body at 24:40... --> src/main.rs:24:40 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | ^^^^^ note: ...so that the type `[closure@src/main.rs:25:17: 27:6]` will meet its required lifetime bounds --> src/main.rs:25:11 | 25 | scope.spawn(move |_| { | ^^^^^ ``` r? `````@estebank`````

…onymous-lifetime, r=estebank Improve anonymous lifetime note to indicate the target span Improvement for rust-lang#81650 Cc rust-lang#81995 Message after this improvement: (Improve note in the middle) ``` error[E0311]: the parameter type `T` may not live long enough --> src/main.rs:25:11 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | -- help: consider adding an explicit lifetime bound...: `T: 'a +` 25 | scope.spawn(move |_| { | ^^^^^ | note: the parameter type `T` must be valid for the anonymous lifetime defined on the function body at 24:40... --> src/main.rs:24:40 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | ^^^^^ note: ...so that the type `[closure@src/main.rs:25:17: 27:6]` will meet its required lifetime bounds --> src/main.rs:25:11 | 25 | scope.spawn(move |_| { | ^^^^^ ``` r? ``````@estebank``````

Fix suggestion to introduce explicit lifetime

788e4bb

rust-highfive assigned matthewjasper Feb 11, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 11, 2021

rust-highfive assigned estebank and unassigned matthewjasper Feb 11, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2021

jonas-schievink mentioned this pull request Feb 11, 2021

Rollup of 16 pull requests #81998

Closed

JohnTitor mentioned this pull request Feb 12, 2021

Rollup of 17 pull requests #82019

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 12, 2021

Add nll test

fcce998

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2021

JohnTitor mentioned this pull request Feb 13, 2021

Rollup of 8 pull requests #82053

Merged

bors merged commit 14b217c into rust-lang:master Feb 13, 2021

rustbot added this to the 1.52.0 milestone Feb 13, 2021

0yoyoyo mentioned this pull request Feb 21, 2021

Improve anonymous lifetime note to indicate the target span #82370

Merged

jackh726 mentioned this pull request Jun 20, 2021

thread 'rustc' panicked at 'Box<Any>': associated type missing default #86483

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix suggestion to introduce explicit lifetime #81995

Fix suggestion to introduce explicit lifetime #81995

Uh oh!

0yoyoyo commented Feb 11, 2021 •

edited by estebank

Loading

Uh oh!

rust-highfive commented Feb 11, 2021

Uh oh!

0yoyoyo commented Feb 11, 2021

Uh oh!

estebank commented Feb 11, 2021

Uh oh!

bors commented Feb 11, 2021

Uh oh!

JohnTitor commented Feb 12, 2021

Uh oh!

0yoyoyo commented Feb 12, 2021

Uh oh!

0yoyoyo commented Feb 12, 2021

Uh oh!

JohnTitor commented Feb 12, 2021

Uh oh!

bors commented Feb 12, 2021

Uh oh!

Uh oh!

Fix suggestion to introduce explicit lifetime #81995

Fix suggestion to introduce explicit lifetime #81995

Uh oh!

Conversation

0yoyoyo commented Feb 11, 2021 • edited by estebank Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Feb 11, 2021

Uh oh!

0yoyoyo commented Feb 11, 2021

Uh oh!

estebank commented Feb 11, 2021

Uh oh!

bors commented Feb 11, 2021

Uh oh!

JohnTitor commented Feb 12, 2021

Uh oh!

0yoyoyo commented Feb 12, 2021

Uh oh!

0yoyoyo commented Feb 12, 2021

Uh oh!

JohnTitor commented Feb 12, 2021

Uh oh!

bors commented Feb 12, 2021

Uh oh!

Uh oh!

0yoyoyo commented Feb 11, 2021 •

edited by estebank

Loading