Cleanup PpMode and friends
#82269
Merged
Cleanup PpMode and friends
#82269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Mhh, maybe r? @jyn514 ? |
This comment has been minimized.
This comment has been minimized.
|
I'm not the right reviewer. r? @pnkfelix maybe? |
LeSeulArtichaut
force-pushed
the
cleanup-ppmode
branch
2 times, most recently
from
013a4a9 to
bd21532
Compare
This comment has been minimized.
This comment has been minimized.
LeSeulArtichaut
force-pushed
the
cleanup-ppmode
branch
from
bd21532 to
927aa00
Compare
LingMan
reviewed
Feb 19, 2021
LeSeulArtichaut
force-pushed
the
cleanup-ppmode
branch
from
927aa00 to
3ed189e
Compare
LeSeulArtichaut
added
C-cleanup
This comment has been minimized.
This comment has been minimized.
LeSeulArtichaut
force-pushed
the
cleanup-ppmode
branch
from
6141b6a to
dd3772e
Compare
|
@bors r+ rollup=always |
|
📌 Commit dd3772e has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 24, 2021
…pastorino Cleanup `PpMode` and friends This PR: - Separates `PpSourceMode` and `PpHirMode` to remove invalid states - Renames the variant to remove the redundant `Ppm` prefix - Adds basic documentation for the different pretty-print modes - Cleanups some code to make it more idiomatic Not sure if this is actually useful, but it looks cleaner to me.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 24, 2021
…pastorino Cleanup `PpMode` and friends This PR: - Separates `PpSourceMode` and `PpHirMode` to remove invalid states - Renames the variant to remove the redundant `Ppm` prefix - Adds basic documentation for the different pretty-print modes - Cleanups some code to make it more idiomatic Not sure if this is actually useful, but it looks cleaner to me.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 24, 2021
…pastorino Cleanup `PpMode` and friends This PR: - Separates `PpSourceMode` and `PpHirMode` to remove invalid states - Renames the variant to remove the redundant `Ppm` prefix - Adds basic documentation for the different pretty-print modes - Cleanups some code to make it more idiomatic Not sure if this is actually useful, but it looks cleaner to me.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 24, 2021
…pastorino Cleanup `PpMode` and friends This PR: - Separates `PpSourceMode` and `PpHirMode` to remove invalid states - Renames the variant to remove the redundant `Ppm` prefix - Adds basic documentation for the different pretty-print modes - Cleanups some code to make it more idiomatic Not sure if this is actually useful, but it looks cleaner to me.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 25, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#82269 (Cleanup `PpMode` and friends) - rust-lang#82431 (Set RUST_BACKTRACE=0 when running `treat-err-as-bug` tests) - rust-lang#82441 (Fix typo in sanitizer flag in unstable book.) - rust-lang#82463 (panic_bounds_checks should be panic_bounds_check) - rust-lang#82464 (Update outdated comment in unix Command.) - rust-lang#82467 (library: Normalize safety-for-unsafe-block comments) - rust-lang#82468 (Move pick_by_value_method docs above function header) - rust-lang#82484 (rustdoc: Remove duplicate "List of all items") - rust-lang#82502 (Only look for HTML `tidy` when running rustdoc tests) - rust-lang#82503 (fix typo in `pre-commit.sh`) - rust-lang#82510 (Fix typo in `param_env_reveal_all_normalized`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 4, 2021
…storino Add `-Z unpretty` flags for the AST Implements rust-lang/compiler-team#408. Builds on rust-lang#82269, but if that PR is rejected or stalls out, I can implement this without rust-lang#82269. cc rust-lang/rustc-dev-guide#1062
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 4, 2021
…orino Add `-Z unpretty` flags for the AST Implements rust-lang/compiler-team#408. Builds on rust-lang#82269, but if that PR is rejected or stalls out, I can implement this without rust-lang#82269. cc rust-lang/rustc-dev-guide#1062
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
PpSourceModeandPpHirModeto remove invalid statesPpmprefixNot sure if this is actually useful, but it looks cleaner to me.