Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

AST: Remove some unnecessary boxes #82321

Merged
merged 1 commit into from
Feb 25, 2021
Merged

AST: Remove some unnecessary boxes #82321

merged 1 commit into from
Feb 25, 2021

Conversation

bugadani
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2021
@varkor
Copy link
Member

varkor commented Feb 22, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Feb 22, 2021

📌 Commit 10f2342 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2021
@bjorn3
Copy link
Member

bjorn3 commented Feb 23, 2021

This may cause ItemKind to become bigger, which can regress performance. I think it is best to do a perf run first.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 23, 2021
@bjorn3
Copy link
Member

bjorn3 commented Feb 23, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 23, 2021
@bors
Copy link
Contributor

bors commented Feb 23, 2021

⌛ Trying commit 10f2342 with merge f958619052ba2fe12fd5f5e9202c5003fe4f1786...

@bugadani
Copy link
Contributor Author

This may cause ItemKind to become bigger

It does not (on x64), according to the static assert in L2761 :)

@bjorn3
Copy link
Member

bjorn3 commented Feb 23, 2021

I missed that line. @bors try-

@bjorn3
Copy link
Member

bjorn3 commented Feb 23, 2021

@bors r-

@bjorn3
Copy link
Member

bjorn3 commented Feb 23, 2021

(how do you cancel a try build)

@bors r- retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 23, 2021
@bjorn3
Copy link
Member

bjorn3 commented Feb 23, 2021

@bors r=varkor

@bors
Copy link
Contributor

bors commented Feb 23, 2021

📌 Commit 10f2342 has been approved by varkor

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 24, 2021
@Dylan-DPC
Rollup merge of rust-lang#82321 - bugadani:ast3, r=varkor
2e1bffc 
AST: Remove some unnecessary boxes
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 24, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 24, 2021
@Dylan-DPC
Rollup merge of rust-lang#82321 - bugadani:ast3, r=varkor
2ffc621 
AST: Remove some unnecessary boxes
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 24, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 24, 2021
@Dylan-DPC
Rollup merge of rust-lang#82321 - bugadani:ast3, r=varkor
461c64f 
AST: Remove some unnecessary boxes
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 24, 2021
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 25, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2021
@bors
Auto merge of rust-lang#82517 - Dylan-DPC:rollup-a1958gb, r=Dylan-DPC
0ab7c1d 
Rollup of 16 pull requests

Successful merges:

 - rust-lang#75807 (Convert core/num/mod.rs to intra-doc links)
 - rust-lang#80534 (Use #[doc = include_str!()] in std)
 - rust-lang#80553 (Add an impl of Error on `Arc<impl Error>`.)
 - rust-lang#81167 (Make ptr::write const)
 - rust-lang#81575 (rustdoc: Name fields of `ResolutionFailure::WrongNamespace`)
 - rust-lang#81713 (Account for associated consts in the "unstable assoc item name colission" lint)
 - rust-lang#82078 (Make char and u8 methods const)
 - rust-lang#82087 (Fix ICE caused by suggestion with no code substitutions)
 - rust-lang#82090 (Do not consider using a semicolon inside of a different-crate macro)
 - rust-lang#82213 (Slices for vecs)
 - rust-lang#82214 (Remove redundant to_string calls)
 - rust-lang#82220 (fix the false 'defined here' messages)
 - rust-lang#82313 (Update normalize.css to 8.0.1)
 - rust-lang#82321 (AST: Remove some unnecessary boxes)
 - rust-lang#82364 (Improve error msgs when found type is deref of expected)
 - rust-lang#82514 (Update Clippy)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 20928e0 into rust-lang:master Feb 25, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 25, 2021
@bugadani bugadani deleted the ast3 branch February 25, 2021 18:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@varkor varkor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-perf Status: Waiting on a perf run to be completed.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bugadani @rust-highfive @varkor @bors @bjorn3 @rust-timer @rustbot