Skip to content

Revert "Update normalize.css to 8.0.1" #82549

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Conversation

GuillaumeGomez
Copy link
Member

Reverts #82313

Fixes #82548
Fixes #82542

@jsha: I'm reverting until we can come up with a new version which is fully working.

r? @jyn514

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Feb 26, 2021
@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2021
@apiraino
Copy link
Contributor

apiraino commented Feb 26, 2021

@bors: r=apiraino

1 similar comment
@apiraino
Copy link
Contributor

@bors: r=apiraino

@bors
Copy link
Collaborator

bors commented Feb 26, 2021

@apiraino: 🔑 Insufficient privileges: Not in reviewers

@GuillaumeGomez
Copy link
Member Author

Considering it's a revert for a small change, I guess it's fine to go ahead. Thanks for the quick reaction @apiraino !

@bors: r=apiraino rollup

@bors
Copy link
Collaborator

bors commented Feb 26, 2021

📌 Commit b0dc39e has been approved by apiraino

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 26, 2021
…lize-css, r=apiraino

Revert "Update normalize.css to 8.0.1"

Reverts rust-lang#82313

Fixes rust-lang#82548
Fixes rust-lang#82542

`@jsha:` I'm reverting until we can come up with a new version which is fully working.

r? `@jyn514`
@jsha
Copy link
Contributor

jsha commented Feb 26, 2021

Sounds good to me, and sorry for the breakage.

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2021
…laumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#81940 (Stabilize str_split_once)
 - rust-lang#82165 (Reword labels on E0308 involving async fn return type)
 - rust-lang#82456 (Replaced some unwrap_or and map_or with lazy variants)
 - rust-lang#82491 (Consider inexpensive inlining criteria first)
 - rust-lang#82506 (Properly account for non-shorthand pattern field in unused variable lint)
 - rust-lang#82535 (Set codegen thread names)
 - rust-lang#82545 (rustdoc: add optional woff2 versions of FiraSans.)
 - rust-lang#82549 (Revert "Update normalize.css to 8.0.1")

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0da9b47 into master Feb 26, 2021
@bors bors deleted the revert-82313-update-normalize-css branch February 26, 2021 21:59
@rustbot rustbot added this to the 1.52.0 milestone Feb 26, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc: button text does not respect color themes rustdoc: Search results have larger margins than before
7 participants