Skip to content

Fix polymorphization ICE on associated types in trait decls using const generics in bounds #82765

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Mar 5, 2021

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 4, 2021

r? @davidtwco

only the last commit actually changes something

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2021
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 4, 2021

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Mar 4, 2021

📌 Commit 29f4aa7 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2021
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 4, 2021

@bors rollup

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 5, 2021
…, r=davidtwco

Fix polymorphization ICE on associated types in trait decls using const generics in bounds

r? ``@davidtwco``

only the last commit actually changes something
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2021
…laumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#76716 (Don't warn for `missing_doc_examples` when item is #[doc(hidden)])
 - rust-lang#82088 (Shorten html::render)
 - rust-lang#82690 (Update rustdoc documentation)
 - rust-lang#82752 (Add a regression test for issue-81712)
 - rust-lang#82765 (Fix polymorphization ICE on associated types in trait decls using const generics in bounds)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Mar 5, 2021
…, r=davidtwco

Fix polymorphization ICE on associated types in trait decls using const generics in bounds

r? ```@davidtwco```

only the last commit actually changes something
@bors bors merged commit f74231f into rust-lang:master Mar 5, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants