Skip to content

Update tests names to start with issue- #82797

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

henryboisdequin
Copy link
Contributor

See @JohnTitor's comment

@rustbot label +C-cleanup

@rustbot rustbot added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Mar 5, 2021
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2021
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that .stderr contains file name so you should bless it.

@henryboisdequin
Copy link
Contributor Author

@JohnTitor thanks, I forgot

@JohnTitor
Copy link
Member

@bors rollup
This is definitely safe to rollup.

@henryboisdequin
Copy link
Contributor Author

r? @JohnTitor

@JohnTitor
Copy link
Member

Sorry but I'm not part of the reviewers so r? @Mark-Simulacrum for final review.

@Xanewok
Copy link
Member

Xanewok commented Mar 5, 2021

Seems like a no-brainer and seems more in line with what we current have (even if we'll have to later rename it to a more meaningful name, as that's the approach we're slowly taking with issue # tests)

r? @Xanewok
@bors r+

@bors
Copy link
Collaborator

bors commented Mar 5, 2021

📌 Commit cb9b10c has been approved by Xanewok

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 5, 2021
…anewok

Update tests names to start with `issue-`

See `@JohnTitor's` [comment](rust-lang#82720 (comment))

`@rustbot` label +C-cleanup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2021
…laumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#80845 (Make ItemKind::ExternCrate looks like hir::ItemKind::ExternCrate to make transition over hir::ItemKind simpler)
 - rust-lang#82708 (Warn on `#![doc(test(...))]` on items other than the crate root and use future incompatible lint)
 - rust-lang#82714 (Detect match arm body without braces)
 - rust-lang#82736 (Bump optimization from mir_opt_level 2 to 3 and 3 to 4 and make "release" be level 2 by default)
 - rust-lang#82782 (Make rustc shim's verbose output include crate_name being compiled.)
 - rust-lang#82797 (Update tests names to start with `issue-`)
 - rust-lang#82809 (rustdoc: Use substrings instead of split to grab enum variant paths)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1a08cb6 into rust-lang:master Mar 6, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 6, 2021
@henryboisdequin henryboisdequin deleted the name-issue-num branch March 6, 2021 02:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants