Skip to content

Stabilize assoc_char_funcs and assoc_char_consts #82919

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2021
Merged

Stabilize assoc_char_funcs and assoc_char_consts #82919

merged 1 commit into from
Mar 20, 2021

Conversation

bstrie
Copy link
Contributor

@bstrie bstrie commented Mar 8, 2021 •
edited
Loading

@rust-highfive
Copy link
Contributor

r? @sfackler

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 8, 2021
@bstrie bstrie added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 8, 2021
@joshtriplett
Copy link
Member

@rfcbot merge

@rfcbot
Copy link
Collaborator

rfcbot commented Mar 16, 2021 •
edited by dtolnay
Loading

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Mar 16, 2021
@rfcbot
Copy link
Collaborator

rfcbot commented Mar 18, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@bors
Copy link
Collaborator

bors commented Mar 19, 2021

☔ The latest upstream changes (presumably #83301) made this pull request unmergeable. Please resolve the merge conflicts.

dtolnay
dtolnay approved these changes Mar 20, 2021
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. These all exactly match the corresponding already-stable APIs in the core::char and std::char modules.

@dtolnay
Copy link
Member

dtolnay commented Mar 20, 2021

Rebased to resolve conflict with #82759 in compiler/rustc_middle/src/lib.rs.

@dtolnay
Copy link
Member

dtolnay commented Mar 20, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 20, 2021

📌 Commit 567f0e1 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2021
@bors
Copy link
Collaborator

bors commented Mar 20, 2021

⌛ Testing commit 567f0e1 with merge eb9ec31...

@bors
Copy link
Collaborator

bors commented Mar 20, 2021

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing eb9ec31 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 20, 2021
@bors bors merged commit eb9ec31 into rust-lang:master Mar 20, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 20, 2021
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Mar 28, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 4, 2021
@pthariensflame
Copy link
Contributor

Needs relnotes?

@bstrie bstrie added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 20, 2021
@dtolnay dtolnay assigned dtolnay and unassigned sfackler Mar 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.

Tracking issue for associated functions and consts of std::char.
10 participants
@bstrie @rust-highfive @joshtriplett @rfcbot @bors @dtolnay @pthariensflame @sfackler @apiraino @rustbot