-
Notifications
You must be signed in to change notification settings - Fork 13.4k
rustc_query_system: simplify QueryCache::iter #83069
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
@rustbot label T-compiler |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 86bb1f6e46da2bd3af3636b3c0117a3de7016bb3 with merge 3050f42c7040dd83f083b829ab12fb12cace445e... |
@Mark-Simulacrum -- out of curiosity, is there any way to cancel the try build? I'm about to push another change. Edit: looks like it cancels automatically on force push or something. Nevermind! :) |
Minor cleanup to reduce a small amount of complexity and code bloat. Reduces the number of mono items in rustc_query_impl by 15%.
86bb1f6
to
adcbe49
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit adcbe49 with merge 1c5d00c1311dca4f3bf740115a22c59a6446125b... |
☀️ Try build successful - checks-actions |
Queued 1c5d00c1311dca4f3bf740115a22c59a6446125b with parent b3e19a2, future comparison URL. |
Finished benchmarking try commit (1c5d00c1311dca4f3bf740115a22c59a6446125b): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
📌 Commit adcbe49 has been approved by |
☀️ Test successful - checks-actions |
Minor cleanup to reduce a small amount of complexity and code bloat.
Reduces the number of mono items in rustc_query_impl by 15%.