Skip to content

rustc_query_system: simplify QueryCache::iter #83069

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

tgnottingham
Copy link
Contributor

Minor cleanup to reduce a small amount of complexity and code bloat.
Reduces the number of mono items in rustc_query_impl by 15%.

@rust-highfive
Copy link
Contributor

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 13, 2021
@tgnottingham
Copy link
Contributor Author

@rustbot label T-compiler

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 13, 2021
@Mark-Simulacrum
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 13, 2021
@bors
Copy link
Collaborator

bors commented Mar 13, 2021

⌛ Trying commit 86bb1f6e46da2bd3af3636b3c0117a3de7016bb3 with merge 3050f42c7040dd83f083b829ab12fb12cace445e...

@tgnottingham
Copy link
Contributor Author

tgnottingham commented Mar 13, 2021

@Mark-Simulacrum -- out of curiosity, is there any way to cancel the try build? I'm about to push another change.

Edit: looks like it cancels automatically on force push or something. Nevermind! :)

Minor cleanup to reduce a small amount of complexity and code bloat.
Reduces the number of mono items in rustc_query_impl by 15%.
@tgnottingham tgnottingham force-pushed the simplify-query-cache-iter branch from 86bb1f6 to adcbe49 Compare March 13, 2021 01:35
@tgnottingham
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Mar 13, 2021

⌛ Trying commit adcbe49 with merge 1c5d00c1311dca4f3bf740115a22c59a6446125b...

@bors
Copy link
Collaborator

bors commented Mar 13, 2021

☀️ Try build successful - checks-actions
Build commit: 1c5d00c1311dca4f3bf740115a22c59a6446125b (1c5d00c1311dca4f3bf740115a22c59a6446125b)

@rust-timer
Copy link
Collaborator

Queued 1c5d00c1311dca4f3bf740115a22c59a6446125b with parent b3e19a2, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (1c5d00c1311dca4f3bf740115a22c59a6446125b): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 13, 2021
@cjgillot
Copy link
Contributor

Good catch!
r? @cjgillot
@bors r+

@bors
Copy link
Collaborator

bors commented Mar 13, 2021

📌 Commit adcbe49 has been approved by cjgillot

@rust-highfive rust-highfive assigned cjgillot and unassigned varkor Mar 13, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2021
@bors
Copy link
Collaborator

bors commented Mar 13, 2021

⌛ Testing commit adcbe49 with merge 56f74c5...

@bors
Copy link
Collaborator

bors commented Mar 13, 2021

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 56f74c5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 13, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants