Skip to content

Do not insert impl_trait_in_bindings opaque definitions twice. #83124

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Mar 14, 2021

The reference to the item already appears inside the OpaqueDef. It does not need to be repeated as a statement.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2021
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 14, 2021

📌 Commit 3612953 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2021
@cjgillot cjgillot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 15, 2021
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 15, 2021

📌 Commit e8b2e7b has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 16, 2021
Do not insert impl_trait_in_bindings opaque definitions twice.

The reference to the item already appears inside the `OpaqueDef`. It does not need to be repeated as a statement.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 17, 2021
Do not insert impl_trait_in_bindings opaque definitions twice.

The reference to the item already appears inside the `OpaqueDef`. It does not need to be repeated as a statement.
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#82774 (Fix bad diagnostics for anon params with ref and/or qualified paths)
 - rust-lang#82826 ((std::net::parser): Fix capitalization of IP version names)
 - rust-lang#83092 (More precise spans for HIR paths)
 - rust-lang#83124 (Do not insert impl_trait_in_bindings opaque definitions twice.)
 - rust-lang#83202 (Show details in cfg version unstable book)
 - rust-lang#83203 (Don't warn about old rustdoc lint names (temporarily))
 - rust-lang#83206 (Update books)
 - rust-lang#83219 (Update cargo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9c7aca5 into rust-lang:master Mar 17, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 17, 2021
@cjgillot cjgillot deleted the iiib branch March 17, 2021 15:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants