Skip to content

use checkout@v2 in CI for master #83201

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 19, 2021
Merged

use checkout@v2 in CI for master #83201

merged 1 commit into from
Mar 19, 2021

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Mar 16, 2021

@rust-highfive
Copy link
Contributor

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 16, 2021
@klensy
Copy link
Contributor Author

klensy commented Mar 16, 2021

Btw, github migrate (or already migrated?) runner ubuntu-latest from ubuntu-18.04 to ubuntu-20.04, it won't break parts of CI?

Those two logs linked, one with 18.04, and other one with 20.04.

@jyn514 jyn514 added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Mar 16, 2021
@klensy
Copy link
Contributor Author

klensy commented Mar 18, 2021

ubuntu-latest switched to 20.04 actions/runner-images#1816

@pietroalbini
Copy link
Member

Thanks!
@bors r+

Btw, github migrate (or already migrated?) runner ubuntu-latest from ubuntu-18.04 to ubuntu-20.04, it won't break parts of CI?

Our main runners are not using the standard ubuntu-latest, we're running on a custom image.

@bors
Copy link
Collaborator

bors commented Mar 18, 2021

📌 Commit 22f2548 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 19, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 19, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 19, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 19, 2021
@Dylan-DPC-zz
Copy link

@bors rollup=never (might interfere with other prs)

@bors
Copy link
Collaborator

bors commented Mar 19, 2021

⌛ Testing commit 22f2548 with merge f5f33ec...

@bors
Copy link
Collaborator

bors commented Mar 19, 2021

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing f5f33ec to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 19, 2021
@bors bors merged commit f5f33ec into rust-lang:master Mar 19, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 19, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants