-
Notifications
You must be signed in to change notification settings - Fork 13.4k
update Miri #83257
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
update Miri #83257
Conversation
@bors r+ p=1 |
📌 Commit 1624fd5 has been approved by |
⌛ Testing commit 1624fd5 with merge 8d8ab35bfd9d142fcf3984be57f95b03950e3d37... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
This PR doesn't change anything about coverage reports...?!? |
Are we seeing this failure in any other PRs? If so, then maybe the change @tmiasko just merged is related, but I don't (yet) see how that change would be related. That PR enabled support for higher But it's possible the coverage failure is related to the MIRI changes in @RalfJung 's PR here. If the PR changes the generated MIR so that the @tmiasko - any thoughts about how your PR could have affected the coverage output in this situation? Looks like coverage passed on at least some other platforms. @RalfJung - Could your changes affect MIR on Windows different from Linux?
|
This PR does not change the generated MIR. It has no effect at all on rustc. It just updates Miri-the-tool, but leaves the core CTFE interpreter engine ("Miri engine") unchanged. |
Got it. I don't see how this could be spurious, but could you do a bors retry and confirm if the failure always happens? |
Already did the retry, the next bors slot is ours. |
☀️ Test successful - checks-actions |
Tested on commit rust-lang/rust@1705a7d. Direct link to PR: <rust-lang/rust#83257> 🎉 miri on windows: build-fail → test-pass (cc @RalfJung @eddyb @oli-obk). 🎉 miri on linux: build-fail → test-pass (cc @RalfJung @eddyb @oli-obk).
Fixes #83242
Cc @rust-lang/miri r? @ghost