Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add rust-analyzer rustc_private option in librustdoc Cargo.toml #83389

Merged
merged 2 commits into from
Mar 23, 2021
Merged

add rust-analyzer rustc_private option in librustdoc Cargo.toml #83389

merged 2 commits into from
Mar 23, 2021

Conversation

njasm
Copy link
Contributor

@njasm njasm commented Mar 22, 2021

This addition will allow to have code completion while hacking rustdoc with rust-analyzer.

more info: https://rust-analyzer.github.io/manual.html#rust-analyzer.rustcSource

r? @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2021
jyn514
jyn514 reviewed Mar 22, 2021
View reviewed changes
@jyn514
Copy link
Member

jyn514 commented Mar 22, 2021

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Mar 22, 2021

📌 Commit 34635ec has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2021
@camelid camelid added A-meta Area: Issues & PRs about the rust-lang/rust repository itself T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 22, 2021
@JohnTitor JohnTitor mentioned this pull request Mar 23, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2021
@bors
Auto merge of rust-lang#83398 - JohnTitor:rollup-om80krv, r=JohnTitor
2bd94f4 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#80705 (Update Source Code Pro and include italics)
 - rust-lang#81917 (Update RELEASES.md for 1.51.0)
 - rust-lang#82732 (Remove theme.js file)
 - rust-lang#83356 (rustdoc: Replace pair of `Option`s with an enum)
 - rust-lang#83384 (rename :pat2018 -> :pat2015)
 - rust-lang#83385 (:arrow_up: rust-analyzer)
 - rust-lang#83389 (add rust-analyzer rustc_private option in librustdoc Cargo.toml)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 263c858 into rust-lang:master Mar 23, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 23, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
6 participants
@njasm @jyn514 @bors @rust-highfive @camelid @rustbot