On stable, suggest removing `#![feature]` for features that have been stabilized #83722

jyn514 · 2021-03-31T20:30:56Z

I don't know how to test this (https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Run.20tests.20without.20enabling.20nightly.20features.3F). I confirmed locally that this gives the
appropriate help with channel = "beta":

error[E0554]: `#![feature]` may not be used on the beta release channel
 --> src/lib.rs:2:1
  |
2 | #![feature(min_const_generics)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the attribute
  |
  = help: the feature `min_const_generics` has been stable since 1.51.0 and no longer requires an attribute to enable

error[E0554]: `#![feature]` may not be used on the beta release channel
 --> src/lib.rs:3:1
  |
3 | #![feature(min_const_generics, min_specialization)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: the feature `min_const_generics` has been stable since 1.51.0 and no longer requires an attribute to enable

error[E0554]: `#![feature]` may not be used on the beta release channel
 --> src/lib.rs:4:1
  |
4 | #![feature(box_patterns)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^

Closes #83715.

rust-highfive · 2021-03-31T20:30:59Z

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

GuillaumeGomez · 2021-04-01T15:06:11Z

I think it shouldn't make this check only on stable. If you are using a feature in nightly which is now stable, I think it's definitely worth it to show a warning there as well (and this case is simpler to test too 😉 ).

jyn514 · 2021-04-01T15:45:37Z

@GuillaumeGomez it already warns on nightly. It's a lint and feature gates are rejected during parsing, which is why it doesn't already show up. That's the main reason I wanted to add a test, because I think whoever added the lint originally expected it to work on all channels.

GuillaumeGomez · 2021-04-01T15:47:24Z

Oh I see, my bad, I misunderstood the context from your comment.

joshtriplett · 2021-04-02T22:40:55Z

@jyn514 This seems like a great idea.

Would it be possible to also provide a rustfix suggestion that deletes the line?

jyn514 · 2021-04-02T22:52:19Z

Would it be possible to also provide a rustfix suggestion that deletes the line?

Hmm, I could only do that if all features in the attribute are stable (consider #![feature(min_const_generics, min_specialization)]). But other than that it seems doable.

jyn514 · 2021-04-02T23:36:22Z

Would it be possible to also provide a rustfix suggestion that deletes the line?

Done.

… stabilized I don't know how to test this. I confirmed locally that this gives the appropriate help with `channel = "beta"`: ``` error[E0554]: `#![feature]` may not be used on the beta release channel --> src/lib.rs:2:1 | 2 | #![feature(min_const_generics)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the attribute | = help: the feature `min_const_generics` has been stable since 1.51.0 and no longer requires an attribute to enable error[E0554]: `#![feature]` may not be used on the beta release channel --> src/lib.rs:3:1 | 3 | #![feature(min_const_generics, min_specialization)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: the feature `min_const_generics` has been stable since 1.51.0 and no longer requires an attribute to enable error[E0554]: `#![feature]` may not be used on the beta release channel --> src/lib.rs:4:1 | 4 | #![feature(box_patterns)] | ^^^^^^^^^^^^^^^^^^^^^^^^^ ```

joshtriplett · 2021-04-03T05:56:38Z

@jyn514 In theory, if you get #![feature(stable_feature, unstable_feature)], it'd be possible to give a rustfix suggestion to delete just stable_feature, , but since the resulting code still won't compile on stable, I don't know if that's worth the extra effort.

This LGTM, and thanks for implementing the rustfix!

jyn514 · 2021-04-19T12:09:09Z

@estebank will you have time to look at this sometime soon?

estebank · 2021-04-21T01:43:17Z

@bors r+

bors · 2021-04-21T01:43:18Z

📌 Commit 53a1105 has been approved by estebank

bors · 2021-04-21T07:23:43Z

⌛ Testing commit 53a1105 with merge d3665eadefdd3fa7a5960ebaf1cfd05ed8d26750...

rust-log-analyzer · 2021-04-21T07:29:42Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2021-04-21T07:31:06Z

💔 Test failed - checks-actions

On stable, suggest removing `#![feature]` for features that have been stabilized I don't know how to test this (https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Run.20tests.20without.20enabling.20nightly.20features.3F). I confirmed locally that this gives the appropriate help with `channel = "beta"`: ``` error[E0554]: `#![feature]` may not be used on the beta release channel --> src/lib.rs:2:1 | 2 | #![feature(min_const_generics)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the attribute | = help: the feature `min_const_generics` has been stable since 1.51.0 and no longer requires an attribute to enable error[E0554]: `#![feature]` may not be used on the beta release channel --> src/lib.rs:3:1 | 3 | #![feature(min_const_generics, min_specialization)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: the feature `min_const_generics` has been stable since 1.51.0 and no longer requires an attribute to enable error[E0554]: `#![feature]` may not be used on the beta release channel --> src/lib.rs:4:1 | 4 | #![feature(box_patterns)] | ^^^^^^^^^^^^^^^^^^^^^^^^^ ``` Closes rust-lang#83715.

bors · 2021-04-23T08:17:24Z

⌛ Testing commit 53a1105 with merge 9a09752f514c67aea71428c9c52245e1ed009643...

bors · 2021-04-23T12:32:24Z

💥 Test timed out

jyn514 · 2021-04-23T12:36:37Z

@bors retry

rust-log-analyzer · 2021-04-23T12:39:52Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

On stable, suggest removing `#![feature]` for features that have been stabilized I don't know how to test this (https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Run.20tests.20without.20enabling.20nightly.20features.3F). I confirmed locally that this gives the appropriate help with `channel = "beta"`: ``` error[E0554]: `#![feature]` may not be used on the beta release channel --> src/lib.rs:2:1 | 2 | #![feature(min_const_generics)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the attribute | = help: the feature `min_const_generics` has been stable since 1.51.0 and no longer requires an attribute to enable error[E0554]: `#![feature]` may not be used on the beta release channel --> src/lib.rs:3:1 | 3 | #![feature(min_const_generics, min_specialization)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: the feature `min_const_generics` has been stable since 1.51.0 and no longer requires an attribute to enable error[E0554]: `#![feature]` may not be used on the beta release channel --> src/lib.rs:4:1 | 4 | #![feature(box_patterns)] | ^^^^^^^^^^^^^^^^^^^^^^^^^ ``` Closes rust-lang#83715.

bors · 2021-04-24T02:25:59Z

⌛ Testing commit 53a1105 with merge a7aba58...

bors · 2021-04-24T04:54:05Z

☀️ Test successful - checks-actions
Approved by: estebank
Pushing a7aba58 to master...

jyn514 added A-diagnostics Area: Messages for errors, warnings, and lints A-stability Area: `#[stable]`, `#[unstable]` etc. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 31, 2021

rust-highfive assigned estebank Mar 31, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2021

jyn514 force-pushed the stable-help branch from 2ae7534 to 9e92ca4 Compare April 2, 2021 23:35

jyn514 force-pushed the stable-help branch from 9e92ca4 to 53a1105 Compare April 2, 2021 23:36

jyn514 mentioned this pull request Apr 6, 2021

rustdoc: Link to the docs on namespaces when an unknown disambiguator is found #83866

Merged

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 21, 2021

Dylan-DPC-zz mentioned this pull request Apr 22, 2021

Rollup of 10 pull requests #84425

Closed

Dylan-DPC-zz mentioned this pull request Apr 22, 2021

Rollup of 12 pull requests #84432

Closed

Dylan-DPC-zz mentioned this pull request Apr 22, 2021

Rollup of 11 pull requests #84454

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 23, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2021

Dylan-DPC-zz mentioned this pull request Apr 23, 2021

Rollup of 13 pull requests #84477

Closed

JohnTitor mentioned this pull request Apr 23, 2021

Rollup of 11 pull requests #84483

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 24, 2021

bors merged commit a7aba58 into rust-lang:master Apr 24, 2021

rustbot added this to the 1.53.0 milestone Apr 24, 2021

jyn514 deleted the stable-help branch April 24, 2021 05:14

jruderman mentioned this pull request Sep 9, 2021

Missing help when trying to enable stabilized library feature on stable #88802

Closed

On stable, suggest removing #![feature] for features that have been stabilized #83722

On stable, suggest removing #![feature] for features that have been stabilized #83722

Uh oh!

Conversation

jyn514 commented Mar 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Mar 31, 2021

Uh oh!

GuillaumeGomez commented Apr 1, 2021

Uh oh!

jyn514 commented Apr 1, 2021

Uh oh!

GuillaumeGomez commented Apr 1, 2021

Uh oh!

joshtriplett commented Apr 2, 2021

Uh oh!

jyn514 commented Apr 2, 2021

Uh oh!

jyn514 commented Apr 2, 2021

Uh oh!

joshtriplett commented Apr 3, 2021

Uh oh!

jyn514 commented Apr 19, 2021

Uh oh!

estebank commented Apr 21, 2021

Uh oh!

bors commented Apr 21, 2021

Uh oh!

bors commented Apr 21, 2021

Uh oh!

rust-log-analyzer commented Apr 21, 2021

Uh oh!

bors commented Apr 21, 2021

Uh oh!

bors commented Apr 23, 2021

Uh oh!

bors commented Apr 23, 2021

Uh oh!

jyn514 commented Apr 23, 2021

Uh oh!

rust-log-analyzer commented Apr 23, 2021

Uh oh!

bors commented Apr 24, 2021

Uh oh!

bors commented Apr 24, 2021

Uh oh!

Uh oh!

On stable, suggest removing `#![feature]` for features that have been stabilized #83722

On stable, suggest removing `#![feature]` for features that have been stabilized #83722

jyn514 commented Mar 31, 2021 •

edited

Loading