-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Rollup of 7 pull requests #83811
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rollup of 7 pull requests #83811
Conversation
…tAddrV6` The following methods are made unstable const under the `const_socketaddr` feature: `SocketAddr` - `ip` - `port` - `is_ipv4` - `is_ipv6` `SocketAddrV4` - `ip` - `port` `SocketAddrV6` - `ip` - `port` - `flowinfo` - `scope_id`
These are currently documented in the API guidelines: https://rust-lang.github.io/api-guidelines/interoperability.html#error-types-are-meaningful-and-well-behaved-c-good-err I think it makes sense to uplift this guideline (in a milder form) into std docs. Printing and producing errors is something that even non-expert users do frequently, so it is useful to give at least some indication of what a typical error message looks like.
Only public items are monomorphization roots. This can be confirmed by noting that this program compiles: ```rust fn foo<T>() { if true { foo::<Option<T>>() } } fn bar() { foo::<()>() } ```
I didn't make these renames in rust-lang#80965 because I didn't want the PR to conflict with rust-lang#80914.
I couldn't find any uses of this CSS. I think it was superseded by the `.notable-traits` CSS class and other similarly-named CSS classes.
Constify methods of `std::net::SocketAddr`, `SocketAddrV4` and `SocketAddrV6` The following methods are made unstable const under the `const_socketaddr` feature (rust-lang#82485): ```rust // std::net impl SocketAddr { pub const fn ip(&self) -> IpAddr; pub const fn port(&self) -> u16; pub const fn is_ipv4(&self) -> bool; pub const fn is_ipv6(&self) -> bool; } impl SocketAddrV4 { pub const fn ip(&self) -> IpAddr; pub const fn port(&self) -> u16; } impl SocketAddrV6 { pub const fn ip(&self) -> IpAddr; pub const fn port(&self) -> u16; pub const fn flowinfo(&self) -> u32; pub const fn scope_id(&self) -> u32; } ``` Note: `SocketAddrV4::ip` and `SocketAddrV6::ip` use pointer casting and depend on the unstable feature `const_raw_ptr_deref`
…ht, r=GuillaumeGomez rustdoc: Rename internal uses of `spotlight` I didn't make these renames in rust-lang#80965 because I didn't want the PR to conflict with rust-lang#80914.
Document "standard" conventions for error messages These are currently documented in the API guidelines: https://rust-lang.github.io/api-guidelines/interoperability.html#error-types-are-meaningful-and-well-behaved-c-good-err I think it makes sense to uplift this guideline (in a milder form) into std docs. Printing and producing errors is something that even non-expert users do frequently, so it is useful to give at least some indication of what a typical error message looks like.
Monomorphization doc fix Only public items are monomorphization roots. This can be confirmed by noting that this program compiles: ```rust fn foo<T>() { if true { foo::<Option<T>>() } } fn bar() { foo::<()>() } ``` See also the [zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Why.20are.20non.20public.20items.20monomorphization.20roots.3F).
…ochenkov add fp-armv8 for ARM_ALLOWED_FEATURES For fixing err in rust-lang/stdarch#1105.
…petrochenkov Remove nightly features in rustc_type_ir `rustc_type_ir` will be used as a type library by Chalk, which we want to be able to build on stable, so this PR removes the current nightly features used.
… r=jonas-schievink Fix rustc_lint_defs documentation typo Found a typo while reading the documentation. This PR fixes it.
@bors r+ p=7 rollup=never |
📌 Commit b2daca7 has been approved by |
⌛ Testing commit b2daca7 with merge 8e196a91fac198c6f38202edd8257ce23526b9e4... |
💥 Test timed out |
@bors retry |
⌛ Testing commit b2daca7 with merge 644a08f2c32a4cf8a4684305051011f3eed49257... |
💔 Test failed - checks-actions |
@bors retry |
⌛ Testing commit b2daca7 with merge e81fe9b1b3c27c061d8dc7914c1fe8a5ea4f8b2b... |
💔 Test failed - checks-actions |
What... @bors retry |
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Test successful - checks-actions |
Successful merges:
std::net::SocketAddr
,SocketAddrV4
andSocketAddrV6
#82487 (Constify methods ofstd::net::SocketAddr
,SocketAddrV4
andSocketAddrV6
)spotlight
#83756 (rustdoc: Rename internal uses ofspotlight
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup