Don't report disambiguator error if link would have been ignored #83865
Conversation
camelid
added
A-diagnostics
|
Some changes occurred in intra-doc-links. cc @jyn514 |
rust-highfive
added
the
S-waiting-on-review
camelid
added
the
A-lints
jyn514
added
S-waiting-on-author
This prevents us from warning on links such as `<hello@example.com>`. Note that we still warn on links such as `<hello@localhost>` because they have no dots in them. However, the links will still work, even though a warning is reported.
camelid
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 45ccd50 has been approved by |
bors
added
S-waiting-on-bors
Don't report disambiguator error if link would have been ignored Fixes rust-lang#83859. This prevents us from warning on links such as `<hello@example.com>`. Note that we still warn on links such as `<hello@localhost>` because they have no dots in them. However, the links will still work, even though a warning is reported. r? ``@jyn514``
Don't report disambiguator error if link would have been ignored Fixes rust-lang#83859. This prevents us from warning on links such as `<hello@example.com>`. Note that we still warn on links such as `<hello@localhost>` because they have no dots in them. However, the links will still work, even though a warning is reported. r? `@jyn514`
Don't report disambiguator error if link would have been ignored Fixes rust-lang#83859. This prevents us from warning on links such as `<hello@example.com>`. Note that we still warn on links such as `<hello@localhost>` because they have no dots in them. However, the links will still work, even though a warning is reported. r? ```@jyn514```
Rollup of 8 pull requests Successful merges: - rust-lang#81922 (Let `#[allow(unstable_name_collisions)]` work for things other than function) - rust-lang#82483 (Use FromStr trait for number option parsing) - rust-lang#82739 (Use the beta compiler for building bootstrap tools when `download-rustc` is set) - rust-lang#83650 (Update Source Serif to release 4.004) - rust-lang#83826 (List trait impls before deref methods in doc's sidebar) - rust-lang#83831 (Add `#[inline]` to IpAddr methods) - rust-lang#83863 (Render destructured struct function param names as underscore) - rust-lang#83865 (Don't report disambiguator error if link would have been ignored) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
@camelid @jyn514 What other syntax doc links may have? |
|
Doclinks can have basically arbitrary syntax - they can be arbitrary markdown or html. The documentation at https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html describes what paths you can use inside a markdown link context, but does not describe the syntax for a markdown link itself. There's a reference here: https://daringfireball.net/projects/markdown/syntax#link |
|
@petrochenkov but yes you are correct, in this case it is not a intra-doc link because |
|
I think a conservative estimate is |
Ok, that's also good enough. |
Fixes #83859.
This prevents us from warning on links such as
<hello@example.com>.Note that we still warn on links such as
<hello@localhost>becausethey have no dots in them. However, the links will still work, even
though a warning is reported.
r? @jyn514