Skip to content

Stabilize const_cell_into_inner. #84087

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Stabilize const_cell_into_inner. #84087

wants to merge 1 commit into from

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Apr 11, 2021 •
edited by JohnTitor
Loading

FCP finished here: #78729 (comment)

blocked on "precise drop analysis" unstable const feature (#73255).

closes #78729

@m-ou-se m-ou-se added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 11, 2021
@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 11, 2021
@rust-log-analyzer

This comment has been minimized.

# to view
@m-ou-se
Copy link
Member Author

m-ou-se commented Apr 11, 2021

Looks like rustc disagrees with our decision to make these const. :)

cc @rust-lang/wg-const-eval

@RalfJung
Copy link
Member

Looks like this is blocked on the "precise drop analysis" unstable const feature (#73255).

@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 11, 2021
@a1phyr a1phyr mentioned this pull request Apr 21, 2021
Closed
4 tasks
@joshtriplett joshtriplett added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2021
@inquisitivecrystal inquisitivecrystal mentioned this pull request Jul 29, 2021
Open
1 task
@bors
Copy link
Collaborator

bors commented Aug 5, 2021

☔ The latest upstream changes (presumably #87768) made this pull request unmergeable. Please resolve the merge conflicts.

@WaffleLapkin
Copy link
Member

Can we stabilize into_inner for atomics only? It shouldn't involve drop at all.

@oli-obk
Copy link
Contributor

oli-obk commented Oct 30, 2021

Considering that all that is missing is a review of rust-lang/rustc-dev-guide#1240 followed by the immediate stabilization of precise const drops, we should probably just wait for that

@m-ou-se m-ou-se force-pushed the stabilize-const-cell-into-inner branch from d938ac3 to 272fda6 Compare December 4, 2021 16:50
@m-ou-se m-ou-se force-pushed the stabilize-const-cell-into-inner branch from 272fda6 to c46a49b Compare December 4, 2021 16:51
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-12 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@WaffleLapkin
Copy link
Member

So, turns out #73255 actually has some blockers (the FCP is cancelled). So I'm raising the same question again: Can we stabilize into_inner for atomics only? 😅

@bors
Copy link
Collaborator

bors commented Dec 15, 2021

☔ The latest upstream changes (presumably #91962) made this pull request unmergeable. Please resolve the merge conflicts.

@est31
Copy link
Member

est31 commented Aug 27, 2022

👋 Hello, I'm writing this comment in this stabilization PR to notify you, the authors of this PR, that #100591 has been merged, which implemented a change in how features are stabilized.

Your PR has been filed before the change, so will likely require modifications in order to comply with the new rules. I recommend you to:

  1. rebase the PR onto latest master, so that uses of the placeholder are possible.
  2. replace the version numbers in the PR with the placeholder CURRENT_RUSTC_VERSION. For language changes, this means the version numbers in accepted.rs (example: 4caedba). For library changes, this means the since fields (example e576a9b).

That's it! The CURRENT_RUSTC_VERSION placeholder will, as part of the release process, be replaced with the version number that the PR merged for. It can be used anywhere in rust-lang/rust, not just accepted.rs and the since fields.

If you have any questions, feel free to drop by the zulip stream, or ping me directly in this PR's thread. Thanks! 👋

@JohnCSimon
Copy link
Member

@m-ou-se
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Nov 27, 2022
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Nov 27, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for #![feature(const_cell_into_inner)]