Skip to content

fix suggestion for unsized function parameters #84313

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2021
Merged

fix suggestion for unsized function parameters #84313

merged 1 commit into from
Apr 19, 2021

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Apr 18, 2021 •
edited
Loading

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2021
petrochenkov
petrochenkov reviewed Apr 18, 2021
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2021
@lcnr lcnr added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 18, 2021
@rust-log-analyzer

This comment has been minimized.

# to view
@petrochenkov
Copy link
Contributor

r=me with commits squashed.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2021
@lcnr
Copy link
Contributor Author

lcnr commented Apr 18, 2021

😅

@bors r=petrochenkov rollup

@bors
Copy link
Collaborator

bors commented Apr 18, 2021

📌 Commit da2acec has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 18, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 18, 2021
@GuillaumeGomez
Rollup merge of rust-lang#84313 - lcnr:sized-err-msg, r=petrochenkov
7f20b6f 
fix suggestion for unsized function parameters

taken from `@fasterthanlime's` article https://fasterthanli.me/articles/whats-in-the-box
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 18, 2021
Closed
@JohnTitor
Copy link
Member

Failed in rollup: #84322 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2021
@lcnr
Copy link
Contributor Author

lcnr commented Apr 19, 2021

@bors r=petrochenkov rollup

@bors
Copy link
Collaborator

bors commented Apr 19, 2021

📌 Commit a8193ca has been approved by petrochenkov

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 19, 2021
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 19, 2021
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 19, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2021
@bors
Auto merge of rust-lang#84342 - Dylan-DPC:rollup-5b40142, r=Dylan-DPC
9d9c2c9 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#84123 (Introduce CompileMonoItem DepNode)
 - rust-lang#84126 (Enable sanitizers for x86_64-unknown-linux-musl)
 - rust-lang#84168 (Lower async fn in traits.)
 - rust-lang#84256 (doc: use U+2212 for minus # floating-point -0.0 remarks)
 - rust-lang#84291 (fix aliasing violations in thread_local_const_init)
 - rust-lang#84313 (fix suggestion for unsized function parameters)
 - rust-lang#84330 (Remove unused footer section)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 349fae3 into rust-lang:master Apr 19, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 19, 2021
@lcnr lcnr deleted the sized-err-msg branch April 20, 2021 18:38
@github-actions github-actions bot mentioned this pull request Apr 23, 2021
Closed
@hellow554 hellow554 mentioned this pull request Apr 28, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lcnr @rust-highfive @rust-log-analyzer @petrochenkov @bors @JohnTitor @rustbot