Stablize {HashMap,BTreeMap}::into_{keys,values} #84328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@rustbot modify labels: +T-libs |
rustbot
added
the
T-libs-api
|
r? @m-ou-se |
This comment has been minimized.
This comment has been minimized.
Folyd
force-pushed
the
stablize_map_into_keys_values
branch
from
23f1611 to
33cc3f5
Compare
jonas-schievink
added
the
relnotes
3 tasks
|
We nowadays try to do the FCP on the tracking issue before the stabilization PR, to avoid starting a new discussion on the feature separate from the tracking issue. I've started the FCP process there: #75294 (comment) |
m-ou-se
added
S-blocked
|
@bors r+ |
|
📌 Commit 33cc3f5 has been approved by |
bors
added
S-waiting-on-bors
|
Oh wait. FCP didn't finish yet. :) @bors r- |
bors
added
S-waiting-on-author
m-ou-se
added
S-blocked
|
FCP finished here: #75294 (comment) @bors r+ rollup |
|
📌 Commit b6f3dbb has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 5, 2021
…, r=m-ou-se
Stablize {HashMap,BTreeMap}::into_{keys,values}
I would propose to stabilize `{HashMap,BTreeMap}::into_{keys,values}`( aka. `map_into_keys_values`).
Closes rust-lang#75294.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 5, 2021
…, r=m-ou-se
Stablize {HashMap,BTreeMap}::into_{keys,values}
I would propose to stabilize `{HashMap,BTreeMap}::into_{keys,values}`( aka. `map_into_keys_values`).
Closes rust-lang#75294.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 6, 2021
…, r=m-ou-se
Stablize {HashMap,BTreeMap}::into_{keys,values}
I would propose to stabilize `{HashMap,BTreeMap}::into_{keys,values}`( aka. `map_into_keys_values`).
Closes rust-lang#75294.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#83507 (Implement RFC 2951: Native link modifiers) - rust-lang#84328 (Stablize {HashMap,BTreeMap}::into_{keys,values}) - rust-lang#84712 (Simplify chdir implementation and minimize unsafe block) - rust-lang#84851 (:arrow_up: rust-analyzer) - rust-lang#84923 (Only compute Obligation `cache_key` once in `register_obligation_at`) - rust-lang#84945 (E0583: Include secondary path in error message) - rust-lang#84949 (Fix typo in `MaybeUninit::array_assume_init` safety comment) - rust-lang#84950 (Revert PR 83866) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would propose to stabilize
{HashMap,BTreeMap}::into_{keys,values}( aka.map_into_keys_values).Closes #75294.