Update closure capture error logging for disjoint captures for disjoint captures #84358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
requested changes
Apr 20, 2021
compiler/rustc_mir/src/borrow_check/diagnostics/region_errors.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_mir/src/borrow_check/diagnostics/explain_borrow.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_mir/src/borrow_check/diagnostics/explain_borrow.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_mir/src/borrow_check/diagnostics/explain_borrow.rs
Outdated
Show resolved
Hide resolved
|
@bors delegate+ |
|
✌️ @ChrisPardy can now approve this pull request |
|
Closes #76005 aswell |
|
@bors r=nikomatsakis |
|
📌 Commit c3da321e55dce55d2081abc9ada4bf56837a4cf8 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit c3da321e55dce55d2081abc9ada4bf56837a4cf8 with merge 2c5be70da85cb08c621b6cd48f9b23e508020f97... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Co-authored-by: Niko Matsakis <niko@alum.mit.edu>
Co-authored-by: Niko Matsakis <niko@alum.mit.edu>
Co-authored-by: Niko Matsakis <niko@alum.mit.edu>
ChrisPardy
force-pushed
the
print_captures_borrowck_rebased
branch
from
c3da321 to
d19c468
Compare
|
@bors r=nikomatsakis |
|
📌 Commit d19c468 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d19c468 with merge a134ad75469a2d429c6383baabcada8f44913c69... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors r=nikomatsakis |
|
📌 Commit 404cc33 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 2, 2021
…_rebased, r=nikomatsakis Update closure capture error logging for disjoint captures for disjoint captures Improved error logging when `#![feature(capture_disjoint_fields)]` is used. Closes rust-lang/project-rfc-2229#8 Closes rust-lang/project-rfc-2229#36 Closes rust-lang/project-rfc-2229#39 Closes rust-lang#76005
|
⌛ Testing commit 404cc33 with merge 67721110c86aa2bc57588bd21b19401c78228f9c... |
|
@bors retry yield |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2021
Rollup of 5 pull requests Successful merges: - rust-lang#84358 (Update closure capture error logging for disjoint captures for disjoint captures) - rust-lang#84392 (Make AssertKind::fmt_assert_args public) - rust-lang#84752 (Fix debuginfo for generators) - rust-lang#84763 (shrink doctree::Module) - rust-lang#84821 (Fix nit in rustc_session::options) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved error logging when
#![feature(capture_disjoint_fields)]is used.Closes rust-lang/project-rfc-2229#8
Closes rust-lang/project-rfc-2229#36
Closes rust-lang/project-rfc-2229#39
Closes #76005