Skip to content

rustdoc: Remove most fields from ExternalCrate #84457

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Apr 23, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Apr 22, 2021

Once #84304 is fixed, I can get rid of ExternCrate altogether in favor of CrateNum, but in the meantime, this shrinks ExternalCrate quite a lot.

This might hurt compile-times; if it does, I can add primitive and keyword queries. I expect this to improve compilemem.

Helps with #76382.

r? GuillaumeGomez

@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. labels Apr 22, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2021
@jyn514
Copy link
Member Author

jyn514 commented Apr 22, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 22, 2021
@bors
Copy link
Collaborator

bors commented Apr 22, 2021

⌛ Trying commit 6c6bd88 with merge 336b6b63c7dd2281785650fb6ce1c4066cffe416...

@bors
Copy link
Collaborator

bors commented Apr 23, 2021

☀️ Try build successful - checks-actions
Build commit: 336b6b63c7dd2281785650fb6ce1c4066cffe416 (336b6b63c7dd2281785650fb6ce1c4066cffe416)

@rust-timer
Copy link
Collaborator

Queued 336b6b63c7dd2281785650fb6ce1c4066cffe416 with parent 5f1aeb5, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (336b6b63c7dd2281785650fb6ce1c4066cffe416): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 23, 2021
@jyn514
Copy link
Member Author

jyn514 commented Apr 23, 2021

Interesting - max RSS looks like noise, but up to -3.8% on instruction count.

@jyn514 jyn514 added I-compiletime Issue: Problems and improvements with respect to compile times. and removed I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. labels Apr 23, 2021
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+

@bors
Copy link
Collaborator

bors commented Apr 23, 2021

📌 Commit 6c6bd88 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2021
@bors
Copy link
Collaborator

bors commented Apr 23, 2021

⌛ Testing commit 6c6bd88 with merge 38abe86bb3b0144123be65349c2afb1a94eb3ed4...

@bors
Copy link
Collaborator

bors commented Apr 23, 2021

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 23, 2021
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 23, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@jyn514
Copy link
Member Author

jyn514 commented Apr 23, 2021

dist-x86_64-apple-alt failed without logs :/

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2021
@bors
Copy link
Collaborator

bors commented Apr 23, 2021

⌛ Testing commit 6c6bd88 with merge 484c619...

@bors
Copy link
Collaborator

bors commented Apr 23, 2021

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 484c619 to master...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. I-compiletime Issue: Problems and improvements with respect to compile times. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants