rustdoc: Remove PrimitiveType::{to_url_str, as_str}
#84466
Conversation
jyn514
added
C-cleanup
This comment has been minimized.
This comment has been minimized.
|
r? @ollie27 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit c5219004c2a65b6c1986d34472084c461490fbac with merge db51f0d2969292fe15066b15efe6961d4a06df4e... |
|
☀️ Try build successful - checks-actions |
|
Queued db51f0d2969292fe15066b15efe6961d4a06df4e with parent 7f4afdf, future comparison URL. |
|
Finished benchmarking try commit (db51f0d2969292fe15066b15efe6961d4a06df4e): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
|
Instruction count looks like noise. Max rss seems very slightly worse, but it's a noisy benchmark so it's hard to tell. I don't have a strong preference either way on whether to land this. |
JohnCSimon
added
S-waiting-on-review
|
It's fine, the fact that we have less code to maintain counterbalance the very small perf regression. Thanks! @bors: r+ |
|
📌 Commit c5219004c2a65b6c1986d34472084c461490fbac has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit c5219004c2a65b6c1986d34472084c461490fbac with merge e5cc30b2b3aa59a36baea405cd51b2385571be48... |
|
Good catch @petrochenkov ! @bors: r- |
bors
added
S-waiting-on-author
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@bors r=GuillaumeGomez rollup |
|
📌 Commit 5079744 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 10 pull requests Successful merges: - rust-lang#83653 (Remove unused code from `rustc_data_structures::sync`) - rust-lang#84466 (rustdoc: Remove `PrimitiveType::{to_url_str, as_str}`) - rust-lang#84880 (Make match in `register_res` easier to read) - rust-lang#84942 (rustdoc: link to stable/beta docs consistently in documentation) - rust-lang#85853 (Warn against boxed DST in `improper_ctypes_definitions` lint) - rust-lang#85939 (Fix suggestion for removing &mut from &mut macro!().) - rust-lang#85966 (wasm: Make simd types passed via indirection again) - rust-lang#85979 (don't suggest unsized indirection in where-clauses) - rust-lang#85983 (Update to semver 1.0.3) - rust-lang#85988 (Note that `ninja = false` goes under `[llvm]`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
These can easily be rewritten in terms of
as_sym, and this avoids bugs where the two get out of sync.I don't expect this to have a perf impact, but I'll start a perf run just in case.