Improve coverage spans for chained function calls #84529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
LingMan
reviewed
Apr 25, 2021
Fixes: rust-lang#84180 For chained function calls separated by the `?` try operator, the function call following the try operator produced a MIR `Call` span that matched the span of the first call. The `?` try operator started a new span, so the second call got no span. It turns out the MIR `Call` terminator has a `func` `Operand` for the `Constant` representing the function name, and the function name's Span can be used to reset the starting position of the span.
richkadel
changed the title
|
Nice. @bors r+ rollup |
|
📌 Commit 41667e8 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2021
Rollup of 5 pull requests Successful merges: - rust-lang#84529 (Improve coverage spans for chained function calls) - rust-lang#84616 (Fix empty dom toggle) - rust-lang#84622 (Make traits with GATs not object safe) - rust-lang#84624 (Make sentence in env::args_os' docs plain and simple) - rust-lang#84642 (Stabilize vec_extend_from_within) Failed merges: - rust-lang#84636 (rustdoc: change aliases attribute to data-aliases) r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #84180
For chained function calls separated by the
?try operator, thefunction call following the try operator produced a MIR
Callspan thatmatched the span of the first call. The
?try operator started a newspan, so the second call got no span.
It turns out the MIR
Callterminator has afuncOperandfor the
Constantrepresenting the function name, and the functionname's Span can be used to reset the starting position of the span.
r? @tmandry
cc: @wesleywiser