-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Update LLVM for more wasm simd updates #84654
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @cuviper (rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
📌 Commit 27fc7cb has been approved by |
Update LLVM for more wasm simd updates This fixes the temporary regression introduced in rust-lang#84339 where the wasm target uses `fpto{s,u}i` intrinsics but the codegen for those intrinsics with the `+nontrapping-fptoint` LLVM feature wasn't very good (aka it didn't use the wasm instruction). The fixes brought in here fix that and also implement the second-to-last simd instruction in LLVM.
Update LLVM for more wasm simd updates This fixes the temporary regression introduced in rust-lang#84339 where the wasm target uses `fpto{s,u}i` intrinsics but the codegen for those intrinsics with the `+nontrapping-fptoint` LLVM feature wasn't very good (aka it didn't use the wasm instruction). The fixes brought in here fix that and also implement the second-to-last simd instruction in LLVM.
Update LLVM for more wasm simd updates This fixes the temporary regression introduced in rust-lang#84339 where the wasm target uses `fpto{s,u}i` intrinsics but the codegen for those intrinsics with the `+nontrapping-fptoint` LLVM feature wasn't very good (aka it didn't use the wasm instruction). The fixes brought in here fix that and also implement the second-to-last simd instruction in LLVM.
This likely causes a rollup failure: #84693 (comment) |
This fixes the temporary regression introduced in rust-lang#84339 where the wasm target uses `fpto{s,u}i` intrinsics but the codegen for those intrinsics with the `+nontrapping-fptoint` LLVM feature wasn't very good (aka it didn't use the wasm instruction). The fixes brought in here fix that and also implement the second-to-last simd instruction in LLVM.
27fc7cb
to
29a12f7
Compare
Attempted to fix with rust-lang/llvm-project#106. Pull in that update, but this also pulls in one more commit, so I picked up the Rust changes in #84681 too. @bors: r=cuviper |
📌 Commit eadcbb5 has been approved by |
☀️ Test successful - checks-actions |
This fixes the temporary regression introduced in #84339 where the wasm
target uses
fpto{s,u}i
intrinsics but the codegen for those intrinsicswith the
+nontrapping-fptoint
LLVM feature wasn't very good (aka itdidn't use the wasm instruction). The fixes brought in here fix that and
also implement the second-to-last simd instruction in LLVM.