Remove unneeded call to with_default_session_globals in rustdoc highlight #84953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
|
This was added in #75775 - @matklad is there any particular reason you added it? Or just copy/pasting existing code?
Hey look, we were right 😆 |
|
Who would have guessed? 😆 |
|
Don't rememeber. I guess, I migrated the old code piece by piece and just forgot to remove this when finally removing the ParseSess. |
|
r=me with CI passing |
This comment has been minimized.
This comment has been minimized.
|
@bors: r=jyn514 |
|
📌 Commit 3c489a3 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 5, 2021
…_default_session_globals, r=jyn514 Remove unneeded call to with_default_session_globals in rustdoc highlight This was the origin of the `Span` bug in rust-lang#84176. cc `@Aaron1011` r? `@jyn514`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 5, 2021
…_default_session_globals, r=jyn514 Remove unneeded call to with_default_session_globals in rustdoc highlight This was the origin of the `Span` bug in rust-lang#84176. cc ``@Aaron1011`` r? ``@jyn514``
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 6, 2021
…_default_session_globals, r=jyn514 Remove unneeded call to with_default_session_globals in rustdoc highlight This was the origin of the `Span` bug in rust-lang#84176. cc ```@Aaron1011``` r? ```@jyn514```
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 6, 2021
…_default_session_globals, r=jyn514 Remove unneeded call to with_default_session_globals in rustdoc highlight This was the origin of the `Span` bug in rust-lang#84176. cc ````@Aaron1011```` r? ````@jyn514````
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 7, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#84409 (Ensure TLS destructors run before thread joins in SGX) - rust-lang#84500 (Add --run flag to compiletest) - rust-lang#84728 (Add test for suggestion to borrow unsized function parameters) - rust-lang#84734 (Add `needs-unwind` and beginning of support for testing `panic=abort` std to compiletest) - rust-lang#84755 (Allow using `core::` in intra-doc links within core itself) - rust-lang#84871 (Disallows `#![feature(no_coverage)]` on stable and beta (using standard crate-level gating)) - rust-lang#84872 (Wire up tidy dependency checks for cg_clif) - rust-lang#84896 (Handle incorrect placement of parentheses in trait bounds more gracefully) - rust-lang#84905 (CTFE engine: rename copy → copy_intrinsic, move to intrinsics.rs) - rust-lang#84953 (Remove unneeded call to with_default_session_globals in rustdoc highlight) - rust-lang#84987 (small nits) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 8, 2021
…ls, r=pnkfelix Rework SESSION_GLOBALS API Fixes rust-lang#84954. <s>Needs rust-lang#84953 to be merged first (I cherry-picked its commits to have CI pass).</s> (done) r? `@Aaron1011`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 8, 2021
…ls, r=oli-obk Rework SESSION_GLOBALS API Fixes rust-lang#84954. <s>Needs rust-lang#84953 to be merged first (I cherry-picked its commits to have CI pass).</s> (done) r? `@Aaron1011`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 8, 2021
…ls, r=oli-obk Rework SESSION_GLOBALS API Fixes rust-lang#84954. <s>Needs rust-lang#84953 to be merged first (I cherry-picked its commits to have CI pass).</s> (done) r? ``@Aaron1011``
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the origin of the
Spanbug in #84176.cc @Aaron1011
r? @jyn514