Make unchecked_{add,sub,mul} inherent methods unstably const #85096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
That's just our unintuitive way of saying that stable const fn can call those intrinsics I think we should have an issue for this feature gate and reference it instead of using "none" Other than that, this PR lgtm |
20 tasks
clarfonthey
force-pushed
the
const_unchecked
branch
from
ea3cc82 to
380bbe8
Compare
|
Added tracking issue for both the methods and the const-ness; figured it didn't make sense to have separate issues for them. |
This comment has been minimized.
This comment has been minimized.
|
from the CI failure I'm guessing we already have a tracking issue for the methods' feature gate? |
|
Nope, it was a method on |
clarfonthey
force-pushed
the
const_unchecked
branch
from
ad09169 to
e6b12c8
Compare
|
Nice! @bors r+ |
|
📌 Commit e6b12c8 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 10, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#85050 (Fix suggestions for missing return type lifetime specifiers) - rust-lang#85075 (Improve "panic message is not a string literal" warning) - rust-lang#85096 (Make unchecked_{add,sub,mul} inherent methods unstably const) - rust-lang#85112 (ensure failing promoteds in const/static bodies are handled correctly) - rust-lang#85146 (Provide io::Seek::rewind) - rust-lang#85147 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intrinsics are marked as being stably const (even though they're not stable by nature of being intrinsics), but the currently-unstable inherent versions are not marked as const. This fixes this inconsistency. Split out of #85017,
r? @oli-obk