Skip to content

Conversation

ghost
Copy link

@ghost ghost commented May 15, 2021

I think it makes sense for unit to have the same doc aliases as tuple does.

@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2021
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented May 22, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 22, 2021

📌 Commit 10c43c3 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2021
Rollup of 6 pull requests

Successful merges:

 - rust-lang#84758 (MSVC: Avoid using jmp stubs for dll function imports)
 - rust-lang#85288 (add an example to explain std::io::Read::read returning 0 in some cases)
 - rust-lang#85334 (Add doc aliases to `unit`)
 - rust-lang#85525 (Fix my mailmap entry)
 - rust-lang#85571 (Remove surplus prepend LinkedList fn)
 - rust-lang#85575 (Fix auto-hide for implementations and implementors.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4430aab into rust-lang:master May 23, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 23, 2021
@ghost ghost deleted the patch-8 branch September 24, 2021 10:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants