Skip to content

Fix deny(invalid_doc_attributes) #85501

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2021
Merged

Fix deny(invalid_doc_attributes) #85501

merged 1 commit into from
Jun 5, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented May 20, 2021

Fixes #85497.

@rust-highfive
Copy link
Contributor

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2021
jyn514
jyn514 commented May 20, 2021
View reviewed changes
@jyn514 jyn514 force-pushed the invalid-doc-attrs branch 2 times, most recently from 669d950 to 9985504 Compare May 20, 2021 03:18
@rust-log-analyzer

This comment has been minimized.

# to view
@jyn514 jyn514 force-pushed the invalid-doc-attrs branch from 9985504 to bcc1a6f Compare May 20, 2021 03:40
@rust-log-analyzer

This comment has been minimized.

# to view
@jyn514 jyn514 force-pushed the invalid-doc-attrs branch from bcc1a6f to ff3065c Compare May 20, 2021 13:54
@rust-log-analyzer

This comment has been minimized.

# to view
@camelid
Copy link
Member

camelid commented May 25, 2021

Does this fix it for it being implicitly denied via deny(warnings) too?

@jyn514 jyn514 force-pushed the invalid-doc-attrs branch from ff3065c to 261f643 Compare June 4, 2021 19:20
@jyn514
Copy link
Member Author

jyn514 commented Jun 4, 2021 •
edited
Loading

Does this fix it for it being implicitly denied via deny(warnings) too?

Yes, I've now added a test case for that (as part of doc-spotlight.rs).

@jyn514 jyn514 added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 4, 2021
@varkor
Copy link
Member

varkor commented Jun 5, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 5, 2021

📌 Commit 261f643 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 5, 2021
@Dylan-DPC
Rollup merge of rust-lang#85501 - jyn514:invalid-doc-attrs, r=varkor
2dd7184 
Fix `deny(invalid_doc_attributes)`

Fixes rust-lang#85497.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 5, 2021
Closed
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 5, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2021
@bors
Auto merge of rust-lang#86032 - GuillaumeGomez:rollup-y3ij27b, r=Guil…
ac3e680 
…laumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#83646 (Add a map method to Bound)
 - rust-lang#85501 (Fix `deny(invalid_doc_attributes)`)
 - rust-lang#85503 (rustdoc: add tooltips to some buttons)
 - rust-lang#85710 (Document `From` impls in path.rs)
 - rust-lang#85760 (Possible errors when accessing file metadata are platform specific)
 - rust-lang#85974 (td align attribute)
 - rust-lang#86014 (msp430 linker does not accept -znoexecstack. Set linker_is_gnu to fal…)

Failed merges:

 - rust-lang#85972 (Rustdoc html fixes)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 515c5af into rust-lang:master Jun 5, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 5, 2021
@jyn514 jyn514 deleted the invalid-doc-attrs branch June 5, 2021 21:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@varkor varkor

Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.

invalid_doc_attributes cannot be allowed or denied
7 participants
@jyn514 @rust-highfive @rust-log-analyzer @camelid @varkor @bors @rustbot