Skip to content

Fix typo in internal documentation for TrustedRandomAccess #85888

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

steffahn
Copy link
Member

@steffahn steffahn commented Jun 1, 2021

next_back is a method of DoubleEndedIterator, not Iterator.

`next_back` is a method of DoubleEndedIterator, not Iterator.
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2021
@Mark-Simulacrum
Copy link
Member

It sounds like this is not actually the right fix from the discussion -- is that right? Should this be closed?

@steffahn
Copy link
Member Author

steffahn commented Jun 3, 2021

@Mark-Simulacrum no, the discussions seemed very tangential to me. I don't think anyone (@pickfire, @the8472) disagrees that this fix of the typo is correct. Other potential improvements on these docs are independent issues.

@Mark-Simulacrum
Copy link
Member

Sounds good, wasn't sure. Typo fix seems reasonable then. @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 3, 2021

📌 Commit c5233b7 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 3, 2021
…access_docs, r=Mark-Simulacrum

Fix typo in internal documentation for `TrustedRandomAccess`

`next_back` is a method of DoubleEndedIterator, not Iterator.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 4, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#85717 (Document `From` impls for cow.rs)
 - rust-lang#85850 (Remove unused feature gates)
 - rust-lang#85888 (Fix typo in internal documentation for `TrustedRandomAccess`)
 - rust-lang#85889 (Restoring the `num_def_ids` function in the CStore API )
 - rust-lang#85899 (jsondocck small cleanup)
 - rust-lang#85937 (Fix bad suggestions for code from proc_macro)
 - rust-lang#85963 (Show `::{{constructor}}` in std::any::type_name().)
 - rust-lang#85977 (Fix linkcheck script from getting out of sync.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f6aaf05 into rust-lang:master Jun 4, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 4, 2021
@steffahn steffahn deleted the fix_internal_trustedrandomaccess_docs branch June 8, 2021 11:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants