Skip to content

[WIP] Introduce SingletonCache for use with ZST query keys #86119

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[WIP] Introduce SingletonCache for use with ZST query keys #86119

wants to merge 8 commits into from

Conversation

Aaron1011
Copy link
Member

r? @ghost

Aaron1011 added 8 commits June 7, 2021 16:35
@Aaron1011
Work on cache
7948340
@Aaron1011
Rename and remove Cell
a277c20
@Aaron1011
Avoid ambiguity by always using parens for query modifiers
a03cf1b 
Otherwise, we can get an ambiguity error (with multiple
comma-separated modifiers) because the parents can either
be parsed as the 'arg', or part of the undifferentiated 'other
arguments'
@Aaron1011
Remove lifetime parameter
0bed2b8
@Aaron1011
Revert "Avoid ambiguity by always using parens for query modifiers"
86edc29 
This reverts commit a03cf1b.
@Aaron1011
Use question mark to avoid ambiguity
e056cb8
@Aaron1011
Use SingletonCacheSelector where possible
6ad3389
@Aaron1011
Run fmt
75ee1ed
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 7, 2021
@bors
Copy link
Collaborator

bors commented Jun 7, 2021

⌛ Trying commit 75ee1ed with merge 1ed439959dd9b1f13c824476eaa0477cfddc3b63...

@bors
Copy link
Collaborator

bors commented Jun 7, 2021

☀️ Try build successful - checks-actions
Build commit: 1ed439959dd9b1f13c824476eaa0477cfddc3b63 (1ed439959dd9b1f13c824476eaa0477cfddc3b63)

@rust-timer
Copy link
Collaborator

Queued 1ed439959dd9b1f13c824476eaa0477cfddc3b63 with parent e4a6032, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (1ed439959dd9b1f13c824476eaa0477cfddc3b63): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 8, 2021
@bjorn3 bjorn3 mentioned this pull request Jun 11, 2021
Merged
@bjorn3
Copy link
Member

bjorn3 commented Jun 11, 2021

Could it be used automatically for ZST query keys in the proc macro?

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 12, 2021
@bstrie bstrie marked this pull request as draft July 28, 2021 20:16
@bstrie
Copy link
Contributor

bstrie commented Jul 28, 2021

Triage here, converting to a Draft PR to remove it from the triage queue.

@Aaron1011 Aaron1011 marked this pull request as ready for review December 6, 2021 22:57
@fee1-dead
Copy link
Member

Could it be used automatically for ZST query keys in the proc macro?

We already map DefId to impl IntoQueryParam<DefId> with declarative macros. It should be relatively easy to map all () keys to the SingletonCache in this PR.

@JohnCSimon
Copy link
Member

Ping from triage:
@Aaron1011 what is the status of this PR?

@JohnCSimon JohnCSimon removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 6, 2022
@JohnCSimon JohnCSimon added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 6, 2022
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 19, 2022
@Dylan-DPC
Copy link
Member

closing as inactive

@Dylan-DPC Dylan-DPC closed this Jun 2, 2022
@Dylan-DPC Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Aaron1011 @rust-timer @bors @bjorn3 @bstrie @fee1-dead @JohnCSimon @Dylan-DPC @apiraino @rustbot