Improve maybe_uninit_extra docs #86220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @scottmcm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
est31
force-pushed
the
maybe-uninit-extra
branch
from
f328e11 to
6036fdb
Compare
This comment has been minimized.
This comment has been minimized.
est31
force-pushed
the
maybe-uninit-extra
branch
from
6036fdb to
24190f4
Compare
This comment has been minimized.
This comment has been minimized.
est31
force-pushed
the
maybe-uninit-extra
branch
from
24190f4 to
4345b1e
Compare
est31
force-pushed
the
maybe-uninit-extra
branch
from
4345b1e to
e441af7
Compare
RalfJung
reviewed
Jun 13, 2021
This comment has been minimized.
This comment has been minimized.
|
Argh, sorry, GH autocomplete went really wrong here... |
RalfJung
reviewed
Jun 13, 2021
est31
force-pushed
the
maybe-uninit-extra
branch
from
e441af7 to
ef6c9e6
Compare
RalfJung
reviewed
Jun 13, 2021
est31
force-pushed
the
maybe-uninit-extra
branch
from
ef6c9e6 to
2375604
Compare
RalfJung
reviewed
Jun 13, 2021
est31
force-pushed
the
maybe-uninit-extra
branch
from
2375604 to
db76996
Compare
RalfJung
reviewed
Jun 14, 2021
|
r=me with the last wording nit resolved. |
|
✌️ @est31 can now approve this pull request |
For reasoning, see rust-lang#63567 (comment)
est31
force-pushed
the
maybe-uninit-extra
branch
from
db76996 to
8710258
Compare
|
@bors r=RalfJung rollup |
|
📌 Commit 8710258 has been approved by |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 14, 2021
Improve maybe_uninit_extra docs For reasoning, see rust-lang#63567 (comment)
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 14, 2021
Improve maybe_uninit_extra docs For reasoning, see rust-lang#63567 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 15, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#80269 (Explain non-dropped sender recv in docs) - rust-lang#82179 (Add functions `Duration::try_from_secs_{f32, f64}`) - rust-lang#85608 (Stabilize `ops::ControlFlow` (just the type)) - rust-lang#85792 (Refactor windows sockets impl methods) - rust-lang#86220 (Improve maybe_uninit_extra docs) - rust-lang#86277 (Remove must_use from ALLOWED_ATTRIBUTES) - rust-lang#86285 (:arrow_up: rust-analyzer) - rust-lang#86294 (Stabilize {std, core}::prelude::rust_*.) - rust-lang#86306 (Add mailmap entries for myself) - rust-lang#86314 (Remove trailing triple backticks in `mut_keyword` docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 12, 2021
Split MaybeUninit::write into new feature gate and stabilize it This splits off the `MaybeUninit::write` function from the `maybe_uninit_extra` feature gate into a new `maybe_uninit_write` feature gate and stabilizes it. Earlier work to improve the documentation of the write function: rust-lang#86220 Tracking issue: rust-lang#63567
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasoning, see #63567 (comment)