Skip to content

shrinking the deprecated span #86320

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2021
Merged

shrinking the deprecated span #86320

merged 3 commits into from
Jul 12, 2021

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Jun 15, 2021 •
edited
Loading

ref: #85617 (comment)

part of #85403

r? @estebank

The reason is that if we use method_span directly, it will cause the in_derive_expansion judgment to fail.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2021
@Rustin170506 Rustin170506 changed the title shrinking the deprecated method span shrinking the deprecated span Jun 15, 2021
Rustin170506
Rustin170506 commented Jun 15, 2021
View reviewed changes
compiler/rustc_middle/src/middle/stability.rs
@@ -226,18 +226,19 @@ fn late_report_deprecation(
suggestion: Option<Symbol>,
lint: &'static Lint,
span: Span,
method_span: Option<Span>,
Copy link
Member Author

@Rustin170506 Rustin170506 Jun 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's not a suitable name for now. But I'm not quite sure what to rename it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

@Rustin170506
Copy link
Member Author

@estebank Ping~ Could you please take a look? I would be very grateful.

@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2021
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 12, 2021

📌 Commit 8c5938d has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2021
@bors
Copy link
Collaborator

bors commented Jul 12, 2021

⌛ Testing commit 8c5938d with merge 955b9c0...

@bors
Copy link
Collaborator

bors commented Jul 12, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 955b9c0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 12, 2021
@bors bors merged commit 955b9c0 into rust-lang:master Jul 12, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 12, 2021
@Rustin170506 Rustin170506 deleted the rustin-patch-fix-span branch July 13, 2021 01:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@estebank estebank estebank left review comments

Assignees

@estebank estebank

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Rustin170506 @estebank @bors @JohnCSimon @rust-highfive @rustbot