Skip to content

fix pretty print for loop #86358

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2021
Merged

fix pretty print for loop #86358

merged 1 commit into from
Jun 28, 2021

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Jun 16, 2021

No description provided.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2021
@klensy
Copy link
Contributor Author

klensy commented Jun 16, 2021

There similar https://github.com/rust-lang/rust/blob/2336406b38db20d1bad30d32914e73af1dd62742/src/test/ui/issues/issue-22777.rs#L10..L12 but additional space here added manually.

@klensy klensy marked this pull request as draft June 17, 2021 09:27
@klensy
Copy link
Contributor Author

klensy commented Jun 17, 2021 •
edited
Loading

Need to fix the same in hir pretty, as ast pretty and hir pretty looks like copy&pasted.

@klensy klensy marked this pull request as ready for review June 18, 2021 09:39
@rust-log-analyzer

This comment has been minimized.

# to view
@Mark-Simulacrum
Copy link
Member

r=me with commits squashed into one

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2021
@klensy
Copy link
Contributor Author

klensy commented Jun 23, 2021

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 23, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 28, 2021

📌 Commit ac72773 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2021
@JohnTitor JohnTitor mentioned this pull request Jun 28, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 28, 2021
@bors
Auto merge of rust-lang#86690 - JohnTitor:rollup-4ukk4yw, r=JohnTitor
a435b49 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#86206 (Fix type checking of return expressions outside of function bodies)
 - rust-lang#86358 (fix pretty print for `loop`)
 - rust-lang#86568 (Don't dist miri or rust-analyzer on stable or beta.)
 - rust-lang#86683 (:arrow_up: rust-analyzer)
 - rust-lang#86687 (Allow anyone to set `perf-regression` label)
 - rust-lang#86688 (Add a regression test for issue-65384)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit de93434 into rust-lang:master Jun 28, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
6 participants
@klensy @rust-highfive @rust-log-analyzer @Mark-Simulacrum @bors @rustbot