Skip to content

Force warnings even when can_emit_warnings == false #86572

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2021
Merged

Force warnings even when can_emit_warnings == false #86572

merged 3 commits into from
Jul 6, 2021

Conversation

rylev
Copy link
Member

@rylev rylev commented Jun 23, 2021 •
edited
Loading

Fixes an issue mentioned in #85512 with --cap-lints overriding --force-warnings.

Fixes #86751

r? @ehuss

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2021
@rylev rylev force-pushed the force-warnings-always branch from 09d9dc8 to f939d70 Compare June 23, 2021 17:19
@rylev rylev added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2021
@bors
Copy link
Collaborator

bors commented Jun 29, 2021

☔ The latest upstream changes (presumably #86009) made this pull request unmergeable. Please resolve the merge conflicts.

@rylev rylev force-pushed the force-warnings-always branch from f939d70 to a3d6905 Compare June 30, 2021 09:19
@rylev rylev requested a review from ehuss June 30, 2021 09:21
@rylev rylev added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2021
@ehuss ehuss mentioned this pull request Jun 30, 2021
Merged
ehuss
ehuss approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

I don't feel comfortable merging as I am not on the compiler team. Maybe @estebank or someone else could take a quick look?

@rylev
Copy link
Member Author

rylev commented Jul 1, 2021

r? @nikomatsakis

(since this is edition related, and he's been looking at a lot of these)

@rust-highfive rust-highfive assigned nikomatsakis and unassigned ehuss Jul 1, 2021
nikomatsakis
nikomatsakis requested changes Jul 6, 2021
View reviewed changes
@rylev rylev requested a review from nikomatsakis July 6, 2021 13:27
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 6, 2021

📌 Commit 5af5a6d has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2021
@bors
Copy link
Collaborator

bors commented Jul 6, 2021

⌛ Testing commit 5af5a6d with merge 238fd72...

@bors
Copy link
Collaborator

bors commented Jul 6, 2021

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing 238fd72 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 6, 2021
@bors bors merged commit 238fd72 into rust-lang:master Jul 6, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 6, 2021
@rylev rylev deleted the force-warnings-always branch July 6, 2021 19:33
@bors bors mentioned this pull request Jul 6, 2021
Closed
4 tasks
This was referenced Jul 7, 2021
Merged
Closed
bors added a commit to rust-lang/cargo that referenced this pull request Jul 12, 2021
@bors
Auto merge of #9662 - ehuss:unignore-fix_edition_2021, r=alexcrichton
a51667c 
Unignore fix_edition_2021.

The issue has been fixed by rust-lang/rust#86572.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ehuss ehuss ehuss approved these changes

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

Failure to update dyn usage in Rust 2018 to 2021 transition
6 participants
@rylev @bors @nikomatsakis @ehuss @rust-highfive @rustbot