Make fmt::Arguments::as_str unstably const
#86655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit b3fbfe4 has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
reviewed
Jun 27, 2021
| @@ -444,8 +444,9 @@ impl<'a> Arguments<'a> { | |||
| /// assert_eq!(format_args!("{}", 1).as_str(), None); | |||
| /// ``` | |||
| #[stable(feature = "fmt_as_str", since = "1.52.0")] | |||
| #[rustc_const_unstable(feature = "const_arguments_as_str", issue = "none")] | |||
There was a problem hiding this comment.
This should have a tracking issue. issue = "none" usually means that this will never be stable.
|
☀️ Test successful - checks-actions |
ghost
mentioned this pull request
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: mostly to move "panic!() in const contexts" forward, making use of
as_strwas mentioned in #85194 (comment) and seems like the simplest way forward.