Skip to content

Stabilize Seek::rewind() #86794

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2021
Merged

Stabilize Seek::rewind() #86794

merged 1 commit into from
Jul 5, 2021

Conversation

inquisitivecrystal
Copy link
Contributor

This stabilizes Seek::rewind. It seemed to fit into one of the existing tests, so I extended that test rather than adding a new one.

Closes #85149.

@rust-highfive
Copy link
Contributor

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2021
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 1, 2021
@JohnTitor JohnTitor added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jul 1, 2021
@inquisitivecrystal inquisitivecrystal changed the title Stabilize Seek::rewind Stabilize Seek::rewind() Jul 2, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Jul 5, 2021

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 5, 2021

📌 Commit 6d34a2e has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Jul 5, 2021

(FCP finished here: #85149 (comment))

@m-ou-se m-ou-se mentioned this pull request Jul 5, 2021
Closed
3 tasks
@JohnTitor JohnTitor mentioned this pull request Jul 5, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 5, 2021
@bors
Auto merge of rust-lang#86891 - JohnTitor:rollup-gy2gan9, r=JohnTitor
952fdf2 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#83581 (Add std::os::unix::fs::DirEntryExt2::file_name_ref(&self) -> &OsStr)
 - rust-lang#85377 (aborts: Clarify documentation and comments)
 - rust-lang#86685 (double-check mutability inside Allocation)
 - rust-lang#86794 (Stabilize `Seek::rewind()`)
 - rust-lang#86852 (Remove some doc aliases)
 - rust-lang#86878 (:arrow_up: rust-analyzer)
 - rust-lang#86886 (Remove `impl Clean for {Ident, Symbol}`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2bc7d4d into rust-lang:master Jul 5, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 5, 2021
@pthariensflame
Copy link
Contributor

@XAMPPRocky This one seems to have been missed for relnotes?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for std::io::Seek::rewind()
8 participants
@inquisitivecrystal @rust-highfive @m-ou-se @bors @pthariensflame @jonas-schievink @JohnTitor @rustbot