Remove impl trait in bindings #87141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
spastorino
commented
Jul 14, 2021
lqd
reviewed
Jul 14, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
remove_impl_trait_in_bindings
branch
from
0f01292 to
31ae616
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
remove_impl_trait_in_bindings
branch
from
31ae616 to
bf7016d
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
remove_impl_trait_in_bindings
branch
5 times, most recently
from
2dc406d to
53a5162
Compare
spastorino
force-pushed
the
remove_impl_trait_in_bindings
branch
from
53a5162 to
9146273
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Jul 19, 2021
spastorino
force-pushed
the
remove_impl_trait_in_bindings
branch
from
dba0da5 to
65b8b51
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
remove_impl_trait_in_bindings
branch
from
65b8b51 to
3e857f5
Compare
|
@bors r=oli-obk |
|
📌 Commit 3e857f5 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jul 20, 2021
Tested on commit rust-lang/rust@a72c360. Direct link to PR: <rust-lang/rust#87141> 💔 miri on windows: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb). 💔 miri on linux: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb).
This was referenced Jul 20, 2021
Merged
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Jul 20, 2021
rustup This test was removed in rustc in rust-lang/rust#87141. We added it in #1430, and possibly that "interesting case in unsizing" is not covered by tests now -- but I don't remember what that case is.^^ If/when `impl Trait` in bindings comes back, we should copy the new rustc tests to Miri as well.
|
Hey could you link to the discussion around this removal, so we can understand the rationale/what might happen in the future? |
|
it's (somewhat succinctly) described in #86729 |
|
I wrote a bit more in the issue |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86729
r? @oli-obk