Rustdoc accessibility: make the sidebar headers actual headers #87210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. |
|
r? @CraftSpider (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Looks good to me overall! Please fix the rustdoc tests and it should be good to go. :) |
This comment has been minimized.
This comment has been minimized.
|
Just to be sure: did you rebase on the master branch? I don't see any other reason why it would fail otherwise... |
notriddle
force-pushed
the
notriddle/rustdoc-sidebar-headers
branch
from
63c724e to
1941764
Compare
|
I figured out the problem. The test case was trying to focus on the |
|
Oh I see! Great catch. :) |
GuillaumeGomez
approved these changes
Jul 17, 2021
|
@bors: r+ |
|
📌 Commit 1941764 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 19, 2021
…laumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#86230 (Add --nocapture option to rustdoc) - rust-lang#87210 (Rustdoc accessibility: make the sidebar headers actual headers) - rust-lang#87227 (Move asm! and global_asm! to core::arch) - rust-lang#87236 (Simplify command-line argument initialization on unix) - rust-lang#87251 (Fix "item info" width) - rust-lang#87256 (Extend HIR-based WF checking to associated type defaults) - rust-lang#87259 (triagebot shortcut config) - rust-lang#87268 (Don't create references to uninitialized data in `List::from_arena`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez
added
beta-accepted
pietroalbini
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 26, 2021
…lacrum Prepare 1.54.0 release This PR builds the stable artifacts for the 1.54.0 release. Backports included: * rust-lang#86696 * rust-lang#87167 * rust-lang#87210 I was *not* able to cherry-pick rust-lang#87390 as that didn't apply cleanly to the stable branch. `@GuillaumeGomez` `@notriddle` could it be possible to get a PR targeting `stable` backporting that fix? Also, this **enables** incremental compilation on the stable channel. r? `@Mark-Simulacrum` cc `@rust-lang/release`
tsoutsman
added a commit
to tsoutsman/rust
that referenced
this pull request
Aug 8, 2021
Closes rust-lang#87828 The issue seems to stem from rust-lang#87210 where code headings were changed from a heading containing code to a heading with the `code-header` class. `rustdoc.css` was updated, but `ayu.css` was missed.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 10, 2021
Fix heading colours in Ayu theme Closes rust-lang#87828 The issue seems to stem from rust-lang#87210 where code headings were changed from a heading containing a `code` element to a heading with the `code-header` class. `rustdoc.css` was updated, but `ayu.css` was missed.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 10, 2021
Fix heading colours in Ayu theme Closes rust-lang#87828 The issue seems to stem from rust-lang#87210 where code headings were changed from a heading containing a `code` element to a heading with the `code-header` class. `rustdoc.css` was updated, but `ayu.css` was missed.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 10, 2021
Fix heading colours in Ayu theme Closes rust-lang#87828 The issue seems to stem from rust-lang#87210 where code headings were changed from a heading containing a `code` element to a heading with the `code-header` class. `rustdoc.css` was updated, but `ayu.css` was missed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #87059
Preview it at: https://notriddle.com/notriddle-rustdoc-test/rustdoc-sidebar-header/std/index.html