Skip to content

Add docs for raw-dylib to unstable book #87315

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

ricobbe
Copy link
Contributor

@ricobbe ricobbe commented Jul 20, 2021

No description provided.

@rust-highfive
Copy link
Contributor

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2021
@GuillaumeGomez
Copy link
Member

r? @joshtriplett

@rust-log-analyzer

This comment has been minimized.

@ricobbe
Copy link
Contributor Author

ricobbe commented Jul 20, 2021

I'm not sure how to provide an example of the feature that will compile in automation: it's only supported on Windows. Further, I don't know if automation tries to link and run the examples from the unstable book, but this particular example depends on an external library.

Is there a way to mark this particular example as exempt from the compilation requirement?

@wesleywiser
Copy link
Member

You should be able to mark the codeblock with ignore like this:

```rust,ignore (partial-example)
impl !Trait for Type {}
```

@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This accurately describes the current state so 👍 but we'll want to make sure as the rest of the feature is implemented, this is revised to remove outdated limitation information.

@wesleywiser
Copy link
Member

r? @wesleywiser

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 27, 2021

📌 Commit 8e84e4d has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 28, 2021
…wesleywiser

Add docs for raw-dylib to unstable book
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 28, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#87315 (Add docs for raw-dylib to unstable book)
 - rust-lang#87330 (Use hashbrown's `extend_reserve()` in `HashMap`)
 - rust-lang#87443 (Don't treat git repos as non-existent when `ignore_git` is set)
 - rust-lang#87453 (Suggest removing unnecessary &mut as help message)
 - rust-lang#87500 (Document math behind MIN/MAX consts on integers)
 - rust-lang#87501 (Remove min_type_alias_impl_trait in favor of type_alias_impl_trait)
 - rust-lang#87507 (SGX mutex is *not* moveable)
 - rust-lang#87513 (bootstrap.py: change `git log` option to indicate desired behavior)
 - rust-lang#87523 (Stop creating a reference then immediately dereferencing it.)
 - rust-lang#87524 (Fix ICE in `diagnostic_hir_wf_check`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 911e22b into rust-lang:master Jul 28, 2021
@rustbot rustbot added this to the 1.56.0 milestone Jul 28, 2021
@ricobbe ricobbe deleted the raw-dylib-unstable-book branch July 28, 2021 20:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants