Update Clippy #87579
Merged
Update Clippy #87579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: [`similar_names`] lint no longer suggests to insert or add an underscore to "fix" too similar names
…ap`, `HashSet`, `Borrow`, `Default`
…null`, `prt::null_mut`
similar_names: No longer suggest inserting or appending an underscore changelog: [`similar_names`] lint no longer suggests to insert or add an underscore to "fix" too similar names
the new diagnostic messages
… r=giraffate Documented constant expression evaluation for `repeat_once` Documents the fact that the `repeat_once` lint evaluates constant expressions --- closes: rust-lang#7306 changelog: none (I don't think it's worth a change log entry, as nothing has really changed) r? `@giraffate` as you've implemented the lint and were part of the discussion in the issue 🙃
Store all HIR owners in the same container This replaces the previous storage in a BTreeMap for each of Item/ImplItem/TraitItem/ForeignItem. This should allow for a more compact storage. Based on rust-lang#83114
This commit closes rust-lang#7389. As stated in the issue, `cargo clippy --help` provides explanation for some flags and states that the rest are same as in `cargo check --help`, even though some clippy specific flags exist. This commit extends the `cargo clippy --help` with two additional flags, - `cargo clippy --fix` - `cargo clippy --no-deps` If there are more flags which are not present in `cargo check --help` please bring these to my attention, I will include these aswell. For now, I noticed only the two flags mentioned above.
Some `clippy::author` improvements changelog: none * Use `Debug` instead of re-implementing it for some things * Fix block trailing expression handing * Don't double print on stmt/expr with `#[clippy::author]` attribute
Enhance needless continue to detect loop {continue;}
Fixes rust-lang#7417
changelog: Report [`needless_continue`] in `loop { continue; }` case
Add to test third party crates list changelog: none
…impl-type, r=camsteffen Prefer a code snipped over formatting the self type (`new_without_default`) Fixes: rust-lang/rust-clippy#7220 changelog: [`new_without_default`]: The `Default` impl block type doesn't use the full type path qualification Have a nice day to everyone reading this 🙃
`--no-deps` filled in with a little more information. Explain that `--fix` implies `--no-deps`. Explain that `--no-deps` is used with `cargo clippy --`, including one example.
Rollup of 3 pull requests Successful merges: - rust-lang#7279 (Adapting the lint list to Clippy's new metadata format) - rust-lang#7298 (Switch CI to new metadata collection) - rust-lang#7420 (Update lint documentation to use markdown headlines) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup changelog: rollup
Rustup r? `@ghost` changelog: none
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rust-highfive
added
the
S-waiting-on-review
|
I still have to rename 2 lints. Let me do that real quick. |
This comment has been minimized.
This comment has been minimized.
self_named_constructor -> self_named_constructors append_instead_of_extend -> extend_with_drain
Rename two lints to comply with our lint naming convention self_named_constructor -> self_named_constructors append_instead_of_extend -> extend_with_drain We don't need to `register_renamed` those lints, since I'll backport them to beta, so the old names won't hit stable. changelog: none (I'll adapt the changelog before merging rust-lang#7498)
|
Ok, this should be ready now. |
|
@bors r+ rollup=iffy p=1 |
|
📌 Commit 8570a36 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Jul 29, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth