Skip to content

Allow more "unknown argument" strings from linker #87641

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

HackAttack
Copy link
Contributor

Some toolchains emit slightly different errors, e.g.

ppc-vle-gcc: error: unrecognized option '-no-pie'

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wesleywiser (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 30, 2021
Some toolchains emit slightly different errors, e.g.

    ppc-vle-gcc: error: unrecognized option '-no-pie'
@HackAttack HackAttack force-pushed the expand-unknown-option-message branch from 4d52562 to 3299235 Compare July 31, 2021 16:37
@wesleywiser
Copy link
Member

Thanks @HackAttack!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 4, 2021

📌 Commit 3299235 has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2021
@bors
Copy link
Collaborator

bors commented Aug 5, 2021

⌛ Testing commit 3299235 with merge d4ad1cf...

@bors
Copy link
Collaborator

bors commented Aug 5, 2021

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing d4ad1cf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 5, 2021
@bors bors merged commit d4ad1cf into rust-lang:master Aug 5, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 5, 2021
@HackAttack HackAttack deleted the expand-unknown-option-message branch August 5, 2021 05:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants