Skip to content

Use a more accurate span on assoc types WF checks #87819

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2021
Merged

Use a more accurate span on assoc types WF checks #87819

merged 1 commit into from
Aug 12, 2021

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Aug 6, 2021

Before

error[E0275]: overflow evaluating the requirement `<FooStruct as Foo>::A == _`
  --> $DIR/issue-21946.rs:8:5
   |
LL |     type A = <FooStruct as Foo>::A;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

after

error[E0275]: overflow evaluating the requirement `<FooStruct as Foo>::A == _`
  --> $DIR/issue-21946.rs:8:14
   |
LL |     type A = <FooStruct as Foo>::A;
   |              ^^^^^^^^^^^^^^^^^^^^^

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2021
jackh726
jackh726 requested changes Aug 6, 2021
View reviewed changes
@jackh726
Copy link
Member

jackh726 commented Aug 6, 2021

r? @jackh726

@rust-highfive rust-highfive assigned jackh726 and unassigned davidtwco Aug 6, 2021
jackh726
jackh726 approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with or without nit

@estebank
Copy link
Contributor Author

estebank commented Aug 9, 2021

@bors r=jackh726

@bors
Copy link
Collaborator

bors commented Aug 9, 2021

📌 Commit c046d62 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2021
@bors
Copy link
Collaborator

bors commented Aug 9, 2021

⌛ Testing commit c046d62 with merge c4c4951e5d69ee922392964f565c81680b7e1cab...

@bors
Copy link
Collaborator

bors commented Aug 9, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2021
@jackh726
Copy link
Member

jackh726 commented Aug 9, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2021
@rust-log-analyzer

This comment has been minimized.

# to view
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 10, 2021
@JohnTitor
Rollup merge of rust-lang#87819 - estebank:assoc-type-span, r=jackh726
304c5b9 
Use a more accurate span on assoc types WF checks

Before
```
error[E0275]: overflow evaluating the requirement `<FooStruct as Foo>::A == _`
  --> $DIR/issue-21946.rs:8:5
   |
LL |     type A = <FooStruct as Foo>::A;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
after
```
error[E0275]: overflow evaluating the requirement `<FooStruct as Foo>::A == _`
  --> $DIR/issue-21946.rs:8:14
   |
LL |     type A = <FooStruct as Foo>::A;
   |              ^^^^^^^^^^^^^^^^^^^^^
```
@JohnTitor JohnTitor mentioned this pull request Aug 10, 2021
Closed
@estebank
Copy link
Contributor Author

@bors retry

@JohnTitor
Copy link
Member

#87811 added one more test that needs a change to span: #87908 (comment)
@bors r-

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 11, 2021
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 11, 2021
@estebank
Copy link
Contributor Author

@bors r=jackh726

@bors
Copy link
Collaborator

bors commented Aug 12, 2021

📌 Commit 3a515ae has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 12, 2021
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 12, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 12, 2021
@bors
Auto merge of rust-lang#87963 - GuillaumeGomez:rollup-e54sbez, r=Guil…
4498e30 
…laumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#87819 (Use a more accurate span on assoc types WF checks)
 - rust-lang#87863 (Fix Windows Command::env("PATH"))
 - rust-lang#87885 (Link to edition guide instead of issues for 2021 lints.)
 - rust-lang#87941 (Fix/improve rustdoc-js tool)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0b950d3 into rust-lang:master Aug 12, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 12, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jackh726 jackh726 jackh726 approved these changes

Assignees

@jackh726 jackh726

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
8 participants
@estebank @rust-highfive @jackh726 @bors @rust-log-analyzer @JohnTitor @davidtwco @rustbot