-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Forbid !
from being used in asm!
output
#87985
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@@ -0,0 +1,17 @@ | |||
// only-x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// only-x86_64 | |
// needs-asm-support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes rollup #88067 to fail because wasm does not have reg
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ok, leave it as only-x86_64
for now then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted
@bors r+ |
📌 Commit 6ec1b53 has been approved by |
Forbid `!` from being used in `asm!` output Fixes rust-lang#87802 r? `@Amanieu`
Forbid `!` from being used in `asm!` output Fixes rust-lang#87802 r? ``@Amanieu``
Forbid `!` from being used in `asm!` output Fixes rust-lang#87802 r? ```@Amanieu```
@bors r+ |
📌 Commit 64e1b63 has been approved by |
☀️ Test successful - checks-actions |
Fixes #87802
r? @Amanieu