Forbid ! from being used in asm! output
#87985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Amanieu
reviewed
Aug 14, 2021
| @@ -0,0 +1,17 @@ | |||
| // only-x86_64 | |||
There was a problem hiding this comment.
Suggested change
| // only-x86_64 | |
| // needs-asm-support |
There was a problem hiding this comment.
This causes rollup #88067 to fail because wasm does not have reg.
There was a problem hiding this comment.
Hmm ok, leave it as only-x86_64 for now then.
|
@bors r+ |
|
📌 Commit 6ec1b53 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 15, 2021
Forbid `!` from being used in `asm!` output Fixes rust-lang#87802 r? `@Amanieu`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 15, 2021
Forbid `!` from being used in `asm!` output Fixes rust-lang#87802 r? ``@Amanieu``
This was referenced Aug 15, 2021
camsteffen
added a commit
to camsteffen/rust
that referenced
this pull request
Aug 15, 2021
Forbid `!` from being used in `asm!` output Fixes rust-lang#87802 r? ```@Amanieu```
|
@bors r+ |
|
📌 Commit 64e1b63 has been approved by |
|
☀️ Test successful - checks-actions |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87802
r? @Amanieu