Trait upcasting coercion (part 3) #88135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri Some changes occured to rustc_codegen_cranelift cc @bjorn3 |
rust-highfive
added
the
S-waiting-on-review
This was referenced Aug 18, 2021
nikomatsakis
requested changes
Aug 19, 2021
|
@bors delegate+ |
|
✌️ @crlf0710 can now approve this pull request |
|
Assertions has been added and CI is green. @bors r=nikomatsakis |
|
📌 Commit c22dfab has been approved by |
bors
added
S-waiting-on-bors
RalfJung
reviewed
Aug 20, 2021
| @@ -759,48 +760,38 @@ fn vtable_trait_first_method_offset<'tcx>( | |||
| pub fn vtable_trait_upcasting_coercion_new_vptr_slot( | |||
| tcx: TyCtxt<'tcx>, | |||
| key: ( | |||
| ty::PolyTraitRef<'tcx>, // trait owning vtable | |||
| ty::PolyTraitRef<'tcx>, // super trait ref | |||
| Ty<'tcx>, // trait object type whose trait owning vtable | |||
There was a problem hiding this comment.
This doesn't quite work out grammatically.
|
☀️ Test successful - checks-actions |
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
Sep 19, 2021
…komatsakis Trait upcasting coercion (part 3) By using separate candidates for each possible choice, this fixes type-checking issues in previous commits. r? `@nikomatsakis`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using separate candidates for each possible choice, this fixes type-checking issues in previous commits.
r? @nikomatsakis