Skip to content

Update LLVM submodule #88395

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Update LLVM submodule #88395

merged 1 commit into from
Sep 1, 2021

Conversation

ricky26
Copy link
Contributor

@ricky26 ricky26 commented Aug 27, 2021

This will capture the two M68k bugfixes to help with #88321.

This will capture the two M68k bugfixes to help with rust-lang#88321.
@rust-highfive
Copy link
Contributor

r? @cuviper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2021
@ricky26
Copy link
Contributor Author

ricky26 commented Aug 27, 2021

CC @glaubitz @jrtc27

@nikic
Copy link
Contributor

nikic commented Aug 27, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 27, 2021

📌 Commit 83744eb has been approved by nikic

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2021
@bors
Copy link
Collaborator

bors commented Aug 30, 2021

⌛ Testing commit 83744eb with merge f6ee13f592c977998c79a1bc9e4e7637ab2db61a...

@bors
Copy link
Collaborator

bors commented Aug 30, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 30, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@ricky26
Copy link
Contributor Author

ricky26 commented Aug 30, 2021

The integration failed for what I believe is an issue unrelated to this PR:

error[E0599]: no method named `unwrap` found for type `bool` in the current scope
   --> src/tools/miri/src/shims/intrinsics.rs:521:76
    |
521 |                     && !layout.might_permit_raw_init(this, /*zero:*/ true).unwrap()
    |                                                                            ^^^^^^ method not found in `bool`

error[E0599]: no method named `unwrap` found for type `bool` in the current scope
   --> src/tools/miri/src/shims/intrinsics.rs:529:77
    |
529 |                     && !layout.might_permit_raw_init(this, /*zero:*/ false).unwrap()
    |                                                                             ^^^^^^ method not found in `bool`

Is this submodule related or is it fallout from #88337?

@nikic
Copy link
Contributor

nikic commented Aug 30, 2021

@bors retry Looks spurious

@ricky26 I believe that miri build failure shouldn't fail the build. It got cancelled for some reason.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2021
@glaubitz
Copy link
Contributor

Hmm, homu failed again. Seems like a random issue.

Can we try this again?

@ricky26
Copy link
Contributor Author

ricky26 commented Aug 31, 2021

Hmm, homu failed again. Seems like a random issue.

Can we try this again?

It's still in the queue - last time it took about 3 days to make it to the front.

@glaubitz
Copy link
Contributor

Hmm, homu failed again. Seems like a random issue.
Can we try this again?

It's still in the queue - last time it took about 3 days to make it to the front.

Ah, I wasn't aware of that. Thanks for the heads-up.

@nikic
Copy link
Contributor

nikic commented Sep 1, 2021

@bors rollup=never One of the changes affects codegen.

@glaubitz
Copy link
Contributor

glaubitz commented Sep 1, 2021

@bors rollup=never One of the changes affects codegen.

Is this the queue that we are waiting for with the newest being on top? https://bors.rust-lang.org/queue/rust

@bors
Copy link
Collaborator

bors commented Sep 1, 2021

⌛ Testing commit 83744eb with merge 00ce166...

@bors
Copy link
Collaborator

bors commented Sep 1, 2021

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 00ce166 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 1, 2021
@bors bors merged commit 00ce166 into rust-lang:master Sep 1, 2021
@rustbot rustbot added this to the 1.56.0 milestone Sep 1, 2021
@ricky26 ricky26 deleted the llvm-submodule branch September 1, 2021 14:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants