Fix: don't document private macros by default #88456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
jyn514
reviewed
Aug 29, 2021
jyn514
added
S-waiting-on-author
|
@bors r+ |
|
📌 Commit 6aacbd8 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
dylni
added a commit
to dylni/os_str_bytes
that referenced
this pull request
Sep 6, 2021
This reverts commit 75729ae. This regression has been fixed: rust-lang/rust#88456
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #88019, I made it so private macros are documented in
--document-private-itemsmode. Unfortunately, it appears that I also accidentally made them be documented when not in--document-private-itemsmode. This PR fixes that and adds a regression test.r? @jyn514 (I hope you don't mind that I keep sending PRs your way)
Fixes #88453.